fix(table): change required for RxJS v6.0 #10407
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this._sort.sortChange
andthis._paginator.page
are of typeEventEmitter<Sort>
andEventEmitter<PageEvent>
.In RxJS 6.0 the
empty
observable returnsObservable<never>
instead of the currentlyObservable<Sort>
andObservable<PageEvent>
. Therefore with RxJS v6.0sortChange
is of typeEventEmitter<Sort>|Observable<never>
andpageChange
is of typeEventEmitter<PageEvent>|Observable<never>
. The union Observable types throwTS2554: Expected 0 arguments, but got 1.
error. Details in ReactiveX/rxjs#3388