Skip to content

fix(table): change required for RxJS v6.0 #10407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bowenni
Copy link
Contributor

@bowenni bowenni commented Mar 14, 2018

this._sort.sortChange and this._paginator.page are of type EventEmitter<Sort> and EventEmitter<PageEvent>.

In RxJS 6.0 the empty observable returns Observable<never> instead of the currently Observable<Sort> and Observable<PageEvent>. Therefore with RxJS v6.0 sortChange is of type EventEmitter<Sort>|Observable<never> and pageChange is of type EventEmitter<PageEvent>|Observable<never>. The union Observable types throw TS2554: Expected 0 arguments, but got 1. error. Details in ReactiveX/rxjs#3388

@bowenni bowenni requested a review from andrewseguin as a code owner March 14, 2018 00:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 14, 2018
@bowenni
Copy link
Contributor Author

bowenni commented Mar 14, 2018

I think the failed tests are unrelated to my changes?
master was already failing on those tests at https://travis-ci.org/angular/material2/jobs/353088323

@crisbeto
Copy link
Member

crisbeto commented Mar 14, 2018

I’ve submitted #10409 to fix the e2e failure.

@admosity
Copy link
Contributor

This issue occurs in rxjs 5.5.x+ (with pipe). I believe this is a typescript 2.7.x issue with stricter type checking.

@andrewseguin
Copy link
Contributor

Needs rebase

@bowenni
Copy link
Contributor Author

bowenni commented Mar 19, 2018

#10482 looks like a super set of this change.
I'm closing this one in favor of #10482

@bowenni bowenni closed this Mar 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants