Skip to content

chore(table): support for typescript 2.7.x #10479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

admosity
Copy link
Contributor

@admosity admosity commented Mar 19, 2018

I'm honestly opening this PR because I don't understand this particular error and it's occurring in my codebase as well. Looks like ternary statements are being type checked now and the way the types resolve appears to be an issue. I've tried a similar reproduction of the types and it seems that the way a ternary resolves for a generic is T<A> | T<B> (assuming the same base class with generic) instead of T<A | B>. Maybe this is a typescript or rxjs issue (or both)?

EDIT: This issue is present with rxjs 5.5.x+ and typescript 2.7.x

This is my simple reproduction:
image

Before:
image

After:
image

Seems that because of the type ambiguity, the resolution for the pipe method is the pipe with no arguments.

@admosity admosity requested a review from andrewseguin as a code owner March 19, 2018 14:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 19, 2018
@admosity
Copy link
Contributor Author

Dupe of #10407

@andrewseguin
Copy link
Contributor

Should be good now - thanks for submitting a PR in advance. It was superseded by #10482

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants