Skip to content

fix(overlay): incorrect bounding box bottom position when page is scrolled and content is flowing upwards #10463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2018
Merged

fix(overlay): incorrect bounding box bottom position when page is scrolled and content is flowing upwards #10463

merged 1 commit into from
Mar 20, 2018

Conversation

crisbeto
Copy link
Member

  • Fixes the bounding box position and height being calculated incorrectly when the overlay's content is flowing upwards and the page has been scrolled down.
  • Fixes the "when scrolled" tests not scrolling the page down.

@crisbeto
fix(overlay): incorrect bounding box bottom position when page is scr…
05721f1 
…olled and content is flowing upwards

* Fixes the bounding box position and height being calculated incorrectly when the overlay's content is flowing upwards and the page has been scrolled down.
* Fixes the "when scrolled" tests not scrolling the page down.
@crisbeto crisbeto requested a review from jelbourn as a code owner March 17, 2018 12:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2018
jelbourn
jelbourn approved these changes Mar 19, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 19, 2018
@andrewseguin andrewseguin merged commit 1dd8a27 into angular:master Mar 20, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin