Skip to content

chore: minor cleanup in icon tests and virtual scrolling #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2018

Conversation

crisbeto
Copy link
Member

  • Removes a file that wasn't being used for anything under cdk-experimental/scrolling.
  • Enables strictMetadataEmit for the scrolling package.
  • Fixes a test for the icons which was leaking out a warning message.

* Removes a file that wasn't being used for anything under `cdk-experimental/scrolling`.
* Enables `strictMetadataEmit` for the scrolling package.
* Fixes a test for the icons which was leaking out a warning message.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 23, 2018
@mmalerba mmalerba merged commit 83ce27c into angular:master May 23, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Fixes a path that wasn't updated in angular#11481, causing the Bazel build to fail.
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 24, 2018
Restores a file that was removed in angular#11481 and ended up breaking the Bazel build.
mmalerba pushed a commit that referenced this pull request May 24, 2018
Restores a file that was removed in #11481 and ended up breaking the Bazel build.
mmalerba pushed a commit that referenced this pull request May 24, 2018
* Removes a file that wasn't being used for anything under `cdk-experimental/scrolling`.
* Enables `strictMetadataEmit` for the scrolling package.
* Fixes a test for the icons which was leaking out a warning message.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants