Skip to content

chore: fix bazel failure #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2018
Merged

chore: fix bazel failure #11487

merged 1 commit into from
May 24, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 24, 2018 •
edited
Loading

Restores a file that was removed in #11481 and ended up breaking the Bazel build.

@crisbeto crisbeto requested a review from jelbourn as a code owner May 24, 2018 05:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 24, 2018
@mmalerba
Copy link
Contributor

it looks like this is causing tests to fail

@crisbeto crisbeto force-pushed the minor-cleanup-7-5 branch 2 times, most recently from 070d50d to bfc3f1a Compare May 24, 2018 05:45
@crisbeto crisbeto requested a review from mmalerba as a code owner May 24, 2018 05:45
@crisbeto crisbeto force-pushed the minor-cleanup-7-5 branch from bfc3f1a to d6d754b Compare May 24, 2018 05:49
@crisbeto crisbeto assigned crisbeto and unassigned mmalerba May 24, 2018
@crisbeto crisbeto force-pushed the minor-cleanup-7-5 branch from d6d754b to 2c0b744 Compare May 24, 2018 05:52
@crisbeto crisbeto added in progress This issue is currently in progress and removed pr: merge safe labels May 24, 2018
@crisbeto crisbeto force-pushed the minor-cleanup-7-5 branch 3 times, most recently from 58e1553 to 1e02265 Compare May 24, 2018 07:26
@crisbeto
chore: fix bazel failure
8d8f40f 
Restores a file that was removed in angular#11481 and ended up breaking the Bazel build.
@crisbeto crisbeto force-pushed the minor-cleanup-7-5 branch from 1e02265 to 8d8f40f Compare May 24, 2018 07:29
@crisbeto crisbeto changed the title chore: fix wrong path in scrolling build config chore: fix bazel failure May 24, 2018
@crisbeto crisbeto added pr: merge safe and removed in progress This issue is currently in progress labels May 24, 2018
@crisbeto crisbeto assigned mmalerba and unassigned crisbeto May 24, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 24, 2018
@mmalerba mmalerba merged commit 69e4ca7 into angular:master May 24, 2018
@ngbot
Copy link

ngbot bot commented May 24, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @googlebot