build: sync bazel angular version placeholder #12635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates the Bazel Angular version that will be replaced within the `npm_package` rule to the required Angular version that has been changed with angular#12089. * Removes an unused NPM script * Adds a small check to the Bazel workspace status script that ensures that both Angular versions are in sync.
googlebot
added
the
cla: yes
devversion
commented
Aug 11, 2018
| @@ -11,6 +11,19 @@ function onError { | |||
| echo "" | |||
| } | |||
|
|
|||
| # Function that throws an error if the Bazel Angular version does not match the | |||
| # required Angular version in the project package.json file. | |||
| function checkBazelAngularVersion { | |||
There was a problem hiding this comment.
@jelbourn Not sure if we want that. I just feel like it could happen more often that we are out-of-sync with the Bazel specific variables.
I can remove that part if desired. I'm sure if we switch to Bazel completely (at some point) , there will be only one placeholder anyway.
mmalerba
added
target: patch
mmalerba
added a commit
that referenced
this pull request
Sep 20, 2018
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
* Updates the Bazel Angular version that will be replaced within the `npm_package` rule to the required Angular version that has been changed with angular#12089. * Removes an unused NPM script * Adds a small check to the Bazel workspace status script that ensures that both Angular versions are in sync.
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
angular#13222) This reverts commit bbd2a61.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm_packagerule to the required Angular version that has been changed with build: fix invalid required angular version #12089.