Skip to content

build: fix invalid required angular version #12089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2018
Merged

build: fix invalid required angular version #12089

merged 1 commit into from
Aug 9, 2018

Conversation

devversion
Copy link
Member

Right now the package.json of the release packages accepts every Angular 6.0.0 beta as a working dependency.

This is not really correct since we depend on the preserveWhitespaces change from beta.6 and also depend on the new Injectable / provider API changes which are spread across the beta versions.

Also makes it easier to change the required angular version (right now it's easy to forget about the property in the build config)

References #10301 and #10216

@devversion devversion added the P2 The issue is important to a large percentage of users, with a workaround label Jul 6, 2018
@devversion devversion requested a review from jelbourn as a code owner July 6, 2018 13:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2018
@CaerusKaru CaerusKaru mentioned this pull request Jul 6, 2018
Merged
@devversion devversion force-pushed the build/fix-invalid-required-ng-version branch from 550ad1d to ca308a1 Compare July 9, 2018 18:01
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jul 9, 2018
@josephperrott josephperrott added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 9, 2018
@devversion
Copy link
Member Author

Since we plan to publish this as part of the next minor, can we already mark it as merge ready to make sure it won't be forgotten? @josephperrott

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2018
@ngbot
Copy link

ngbot bot commented Jul 9, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure conflicts with base branch "master"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot
Copy link

ngbot bot commented Jul 11, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@devversion devversion force-pushed the build/fix-invalid-required-ng-version branch from ca308a1 to bfdd4ff Compare July 11, 2018 15:18
@ngbot
Copy link

ngbot bot commented Jul 18, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@josephperrott josephperrott added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jul 18, 2018
@devversion devversion force-pushed the build/fix-invalid-required-ng-version branch from bfdd4ff to b4c3dee Compare July 18, 2018 18:27
@devversion
Copy link
Member Author

@josephperrott Rebased.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jul 22, 2018
@devversion devversion force-pushed the build/fix-invalid-required-ng-version branch from b4c3dee to fada3a6 Compare July 24, 2018 17:15
@devversion devversion added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Jul 24, 2018
@angular angular deleted a comment from ngbot bot Jul 24, 2018
@devversion
build: fix invalid required angular version
fdebd41 
* Right now the `package.json` of the release packages accepts every Angular 6.0.0 beta as a working dependency. This is not really correct since we depend on the `preserveWhitespaces` change from `beta.6` and also depend on the new `Injectable` / `provider` syntax from `beta.4`. We either need to require a version `>= beta.6` or just go to the `6.0.0` stable release.
* Makes it easier to change the required angular version (right now it's easy to forget about the property in the build config)
@devversion devversion force-pushed the build/fix-invalid-required-ng-version branch from fada3a6 to fdebd41 Compare July 30, 2018 22:01
@josephperrott josephperrott merged commit a2c6dfc into angular:master Aug 9, 2018
josephperrott pushed a commit that referenced this pull request Aug 9, 2018
@devversion @josephperrott
build: fix invalid required angular version (#12089)
b63d0ee
devversion added a commit to devversion/material2 that referenced this pull request Aug 11, 2018
@devversion
build: sync bazel angular version placeholder
c681667 
* Updates the Bazel Angular version that will be replaced within the `npm_package` rule to the required Angular version that has been changed with angular#12089.
* Removes an unused NPM script
* Adds a small check to the Bazel workspace status script that ensures that both Angular versions are in sync.
@devversion devversion mentioned this pull request Aug 11, 2018
Merged
mmalerba pushed a commit that referenced this pull request Sep 20, 2018
@devversion @mmalerba
build: sync bazel angular version placeholder (#12635)
bbd2a61 
* Updates the Bazel Angular version that will be replaced within the `npm_package` rule to the required Angular version that has been changed with #12089.
* Removes an unused NPM script
* Adds a small check to the Bazel workspace status script that ensures that both Angular versions are in sync.
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@devversion @roboshoes
build: sync bazel angular version placeholder (angular#12635)
a4a653e 
* Updates the Bazel Angular version that will be replaced within the `npm_package` rule to the required Angular version that has been changed with angular#12089.
* Removes an unused NPM script
* Adds a small check to the Bazel workspace status script that ensures that both Angular versions are in sync.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @josephperrott