build: example list outputting quoted components #13955
Conversation
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
added
pr: lgtm
action: merge
|
I saw and merged Joey's change for this first- do you still want to get this in? |
|
I’m not super attached to it, but it should be a bit more sustainable than constructing the JSON ourselves. |
|
I'll take a look if you want to rebase |
In c64503e the logic that outputs the list of components was reworked to use `JSON.stringify`. As a result, the data that is generated has the `component` inside quotes, rather than a reference to the component class itself. This breaks the demo app. The following changes add some extra logic to remove the quotes around the `component`.
crisbeto
force-pushed
the
example-component-quotes
branch
from
8e7fa1a to
e72ebe9
Compare
|
Rebased @jelbourn. |
| .replace('${exampleList}', `[${exampleList}]`); | ||
| .replace('${exampleComponents}', JSON.stringify(exampleComponents)) | ||
| .replace('${exampleList}', `[${exampleList}]`) | ||
| .replace(new RegExp(`"${quotePlaceholder}|${quotePlaceholder}"`, 'g'), ''); |
There was a problem hiding this comment.
The only part I am not sure I am understanding is the or in regex here?
why are we looking for ◬|◬ instead of just ◬ since we are global matching
There was a problem hiding this comment.
@crisbeto add merge ready once your ready.
There was a problem hiding this comment.
Note the quotes inside it. It looks for "◬|◬" (e.g. "◬something◬").
josephperrott
removed
the
action: merge
In c64503e the logic that outputs the list of components was reworked to use `JSON.stringify`. As a result, the data that is generated has the `component` inside quotes, rather than a reference to the component class itself. This breaks the demo app. The following changes add some extra logic to remove the quotes around the `component`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In c64503e the logic that outputs the list of components was reworked to use
JSON.stringify. As a result, the data that is generated has thecomponentinside quotes, rather than a reference to the component class itself. This breaks the demo app. The following changes add some extra logic to remove the quotes around thecomponent.