Skip to content

fix(snackbar): set aria role based on if announcement message is provided #13993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix(snackbar): set aria role based on if announcement message is provided #13993

merged 1 commit into from
Nov 7, 2018

Conversation

josephperrott
Copy link
Member

Fixes #13116

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 5, 2018
@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Nov 5, 2018
crisbeto
crisbeto approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/example-module/generate-example-module.ts Outdated
};

return result;
const exampleComponents = parsedData.map((metaData) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these changes be reverted? They're sorted out in #13955.

jelbourn
jelbourn reviewed Nov 5, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for the behavior change?

@josephperrott
Copy link
Member Author

Added tests.

jelbourn
jelbourn approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker Accessibility This issue is related to accessibility (a11y) labels Nov 6, 2018
@vivian-hu-zz vivian-hu-zz merged commit 69ffd33 into angular:master Nov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@josephperrott
fix(snackbar): set aria role based on if announcement message is prov…
199583b 
…ided (#13993)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott josephperrott deleted the snackbar-a11y branch March 20, 2020 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent mat-snackbar screenreader behavior
5 participants
@josephperrott @jelbourn @crisbeto @googlebot @vivian-hu-zz