refactor(drag-drop): expose more private apis as protected #14134
Conversation
| @@ -321,13 +321,13 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy { | |||
| } | |||
|
|
|||
| /** Gets only handles that are not inside descendant `CdkDrag` instances. */ | |||
| private getChildHandles() { | |||
| protected _getChildHandles() { | |||
There was a problem hiding this comment.
We might be inconsistent about this, but the coding standards doc says no prefix for protected
There was a problem hiding this comment.
Doing a quick code search shows that most of the protected APIs we have at the moment are underscored.
There was a problem hiding this comment.
Ack, let's revisit this another time
| @@ -321,13 +321,13 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy { | |||
| } | |||
|
|
|||
| /** Gets only handles that are not inside descendant `CdkDrag` instances. */ | |||
| private getChildHandles() { | |||
| protected _getChildHandles() { | |||
There was a problem hiding this comment.
Ack, let's revisit this another time
jelbourn
added
pr: lgtm
action: merge
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
14113/drag-drop-api-update
branch
from
74edb5a to
4bcd13d
Compare
|
@crisbeto API golds need to be updated |
crisbeto
force-pushed
the
14113/drag-drop-api-update
branch
from
4bcd13d to
52718c6
Compare
|
@jelbourn the golden has been updated. |
crisbeto
force-pushed
the
14113/drag-drop-api-update
branch
2 times, most recently
from
fe94d15 to
bd2405c
Compare
|
@crisbeto needs rebase |
crisbeto
force-pushed
the
14113/drag-drop-api-update
branch
from
bd2405c to
293c1fa
Compare
|
Rebased @mmalerba. |
Exposes more of the private drag&drop APIs as protected ones, in order to make it easier for people to implement their custom directives based on the CDK ones. Also moves out some of the private helper methods into functions. Fixes angular#14113.
crisbeto
force-pushed
the
14113/drag-drop-api-update
branch
from
293c1fa to
087bbb5
Compare
|
Closing this PR since it'll increase the API surface a lot and it won't be necessary anymore once we add a service around #14350. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Exposes more of the private drag&drop APIs as protected ones, in order to make it easier for people to implement their custom directives based on the CDK ones. Also moves out some of the private helper methods into functions.
Fixes #14113.