Skip to content

build: switch to browser-sync #14295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2018
Merged

build: switch to browser-sync #14295

merged 1 commit into from
Nov 27, 2018

Conversation

devversion
Copy link
Member

Switches the gulp-connect dev-server to browser-sync

@devversion
build: switch to browser-sync
df2244e 
Switches the gulp-connect dev-server to browser-sync
@devversion devversion added the in progress This issue is currently in progress label Nov 27, 2018
@devversion devversion requested a review from jelbourn as a code owner November 27, 2018 16:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 27, 2018
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release and removed in progress This issue is currently in progress labels Nov 27, 2018
josephperrott
josephperrott reviewed Nov 27, 2018
View reviewed changes
tools/gulp/util/task_helpers.ts
port: 4200,
host: '0.0.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add host: '0.0.0.0' back in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browserstack is actually smarter about this and does this automatically. It also prints out your external host address in the terminal.

jelbourn
jelbourn approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 27, 2018
@jelbourn jelbourn merged commit 141afcf into angular:master Nov 27, 2018
@devversion devversion deleted the build/switch-to-browsersync branch November 27, 2018 17:26
@devversion devversion mentioned this pull request Nov 27, 2018
Closed
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
@devversion @jelbourn
build: switch to browser-sync (#14295)
ce8a938 
Switches the gulp-connect dev-server to browser-sync
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: switch to browser-sync (angular#14295)
71f3c31 
Switches the gulp-connect dev-server to browser-sync
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @josephperrott @googlebot