adds virtual scroll adapter #14287

BenLayet · 2018-11-27T10:51:33Z

As discussed in #10122

I order to integrate virtual scroll into mat table we need to decouple CdkVirtualScrollViewport from CdkVirtualForOf

This modification introduces an adapter between the 2 classes, so users can provide their own version of
CdkVirtualScrollAdapter

suggested by @shlomiassaf,

googlebot · 2018-11-27T10:51:36Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

BenLayet · 2018-11-27T12:11:07Z

I signed it!

googlebot · 2018-11-27T12:11:10Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

BenLayet · 2018-11-27T12:24:51Z

I signed it!

googlebot · 2018-11-27T14:09:54Z

CLAs look good, thanks!

BenLayet · 2018-11-27T14:28:53Z

It seems that CI check fail for a reason independant of my modifications.

error An unexpected error occurred: "https://registry.yarnpkg.com/flatmap-stream/-/flatmap-stream-0.1.1.tgz: Request failed \"404 Not Found\"".

Is there someone looking at the PR even if the checks fail ?

IlCallo · 2018-11-27T14:40:37Z

Related to this attack of some days ago:
dominictarr/event-stream#116

That package was malicious code and has been removed from the registry

devversion · 2018-11-27T18:40:36Z

We've fixed this issue with #14295. If you rebase your PR, the tests should run as you would expect.

BenLayet · 2018-11-27T18:54:18Z

Thank you @IlCallo for the info.
Do you know if the bot will retry the checks once this is fixed ?

IlCallo · 2018-11-27T19:44:36Z

As dev said, you should fetch from upstream, rebase and force push.

Some useful instructions are written into CONTRIBUTING file, I think

pull from angular master

pull angular master

mmalerba · 2018-12-03T18:32:40Z

Looks good, but I would like if we could come up with a better name than CdkVirtualScrollAdapter. @jelbourn @crisbeto any naming ideas?

crisbeto

@mmalerba I don't think I have a better name for the adapter. I was thinking about CdkVirtualScrollDataSource, but that could be confused with the ones on table and tree.

crisbeto · 2018-12-03T20:54:10Z

src/cdk/scrolling/public-api.ts

@@ -14,3 +14,4 @@ export * from './viewport-ruler';
 export * from './virtual-for-of';
 export * from './virtual-scroll-strategy';
 export * from './virtual-scroll-viewport';
+export * from './virtual-scroll-adapter';


Needs an extra newline at the end of the file.

crisbeto · 2018-12-03T20:54:35Z

src/cdk/scrolling/virtual-scroll-adapter.ts

+import {Observable} from 'rxjs';
+import {ListRange} from '../collections';
+
+export interface CdkVirtualScrollAdapter<T> {


This needs some docs explaining what it does and what it's useful for.

crisbeto · 2018-12-03T20:57:14Z

src/cdk/scrolling/virtual-scroll-adapter.ts

+import {ListRange} from '../collections';
+
+export interface CdkVirtualScrollAdapter<T> {
+  dataStream: Observable<T[] | ReadonlyArray<T>>;


@mmalerba shouldn't we call this a dataSource for consistency with some of the other components?

Actually this is different than the dataSource, in the case of cdkVirtualForOf this stream is created by connecting to the data source, but it doesn't have to be.

jelbourn · 2018-12-03T22:54:59Z

src/cdk/scrolling/virtual-scroll-adapter.ts

+import {Observable} from 'rxjs';
+import {ListRange} from '../collections';
+
+export interface CdkVirtualScrollAdapter<T> {


How about CdkVirtualScrollRepeater?

CRACKISH · 2019-01-25T10:35:31Z

How are you doing on this request? I need this feature ))

CharlBest · 2019-02-28T15:05:11Z

Will this pull request help with #13862 and if so is there any timeline to get this in?

Splaktar · 2019-05-14T06:32:49Z

@ben-henoida thank you for making your first contribution with this PR. Can you please address some of the review feedback above? Please let us know if you run into any issues or have questions about how to do that.

mmalerba · 2019-08-12T18:21:31Z

Closing due to inactivity

angular-automatic-lock-bot · 2019-09-12T00:02:28Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

BenLayet requested review from andrewseguin and crisbeto as code owners November 27, 2018 10:51

googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Nov 27, 2018

adds virtual scroll adapater

f326ec6

BenLayet force-pushed the virtual-scroll-with-adapter branch from a08d922 to f326ec6 Compare November 27, 2018 14:09

googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Nov 27, 2018

BenLayet mentioned this pull request Nov 27, 2018

virtual-scroll: integrate with relevant existing components #10122

Open

10 tasks

ben-henoida added 2 commits November 27, 2018 22:17

Merge pull request #1 from angular/master

f6b396b

pull from angular master

Merge pull request #2 from ben-henoida/master

1edc733

pull angular master

crisbeto assigned mmalerba Nov 28, 2018

crisbeto reviewed Dec 3, 2018

View reviewed changes

jelbourn reviewed Dec 3, 2018

View reviewed changes

literalpie mentioned this pull request Jan 20, 2019

refactor: add virtual scroll adapter #14898

Closed

mmalerba mentioned this pull request Apr 8, 2019

cdk-virtual-scroll-viewport - support window scroll #13862

Closed

mmalerba added aaa and removed aaa labels Apr 25, 2019

literalpie mentioned this pull request Jun 30, 2019

refactor: add virtual scroll repeater interface #16412

Closed

mmalerba closed this Aug 12, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds virtual scroll adapter #14287

adds virtual scroll adapter #14287

BenLayet commented Nov 27, 2018

googlebot commented Nov 27, 2018

BenLayet commented Nov 27, 2018

googlebot commented Nov 27, 2018

BenLayet commented Nov 27, 2018

googlebot commented Nov 27, 2018

BenLayet commented Nov 27, 2018

IlCallo commented Nov 27, 2018

devversion commented Nov 27, 2018

BenLayet commented Nov 27, 2018

IlCallo commented Nov 27, 2018

mmalerba commented Dec 3, 2018

crisbeto left a comment

crisbeto Dec 3, 2018

crisbeto Dec 3, 2018

crisbeto Dec 3, 2018

mmalerba Dec 3, 2018

jelbourn Dec 3, 2018

CRACKISH commented Jan 25, 2019

CharlBest commented Feb 28, 2019

Splaktar commented May 14, 2019

mmalerba commented Aug 12, 2019

angular-automatic-lock-bot bot commented Sep 12, 2019

adds virtual scroll adapter #14287

adds virtual scroll adapter #14287

Conversation

BenLayet commented Nov 27, 2018

googlebot commented Nov 27, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

BenLayet commented Nov 27, 2018

googlebot commented Nov 27, 2018

BenLayet commented Nov 27, 2018

googlebot commented Nov 27, 2018

BenLayet commented Nov 27, 2018

IlCallo commented Nov 27, 2018

devversion commented Nov 27, 2018

BenLayet commented Nov 27, 2018

IlCallo commented Nov 27, 2018

mmalerba commented Dec 3, 2018

crisbeto left a comment

Choose a reason for hiding this comment

crisbeto Dec 3, 2018

Choose a reason for hiding this comment

crisbeto Dec 3, 2018

Choose a reason for hiding this comment

crisbeto Dec 3, 2018

Choose a reason for hiding this comment

mmalerba Dec 3, 2018

Choose a reason for hiding this comment

jelbourn Dec 3, 2018

Choose a reason for hiding this comment

CRACKISH commented Jan 25, 2019

CharlBest commented Feb 28, 2019

Splaktar commented May 14, 2019

mmalerba commented Aug 12, 2019

angular-automatic-lock-bot bot commented Sep 12, 2019