Skip to content

refactor: add virtual scroll adapter #14898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

literalpie
Copy link
Contributor

taking over for PR #14287 which has gone a while without updates. Includes changes to address comments

As discussed in #10122

In order to integrate virtual scroll into mat table we need to decouple CdkVirtualScrollViewport from CdkVirtualForOf

This modification introduces an adapter between the 2 classes, so users can provide their own version of
CdkVirtualScrollAdapter CdkVirtualScrollRepeater

suggested by @shlomiassaf,

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2019
@literalpie literalpie closed this Jan 23, 2019
@sumigoma
Copy link

sumigoma commented Feb 4, 2019

@literalpie any particular reason why you closed this?

@literalpie
Copy link
Contributor Author

Mostly just second guessing whether I want to own this. I admit I don't totally understand what's going on, so when I saw that the build failed, I wimped out

@CharlBest
Copy link

Haha so honest :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants