build: group examples by package and entry-point name #16822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/restructure-examples
branch
3 times, most recently
from
f2afdcd to
08cee99
Compare
Groups the examples by package and entry-point name. This allows us have a bazel build target for each group and also allows us to separate MDC prototypes from standard implementations.
devversion
force-pushed
the
build/restructure-examples
branch
from
08cee99 to
4cf8325
Compare
devversion
added
pr: merge safe
target: patch
jelbourn
approved these changes
Aug 20, 2019
| EXAMPLE_PACKAGES = [ | ||
| # TODO(devversion): try to have for each entry-point a bazel package so that | ||
| # we can automate this using the "package.bzl" variables. | ||
| "//src/material-examples/cdk/a11y", |
There was a problem hiding this comment.
For a follow-up, we should probably split this is into src/material-examples and src/cdk-examples
There was a problem hiding this comment.
Yes that was one of the ideas when I made separate directories 😄 It just involves a bit more work for now since our docs only expect one examples package right now.
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
Groups the examples by package and entry-point name. This allows us have a bazel build target for each group and also allows us to separate MDC prototypes from standard implementations. (cherry picked from commit d3a9a20)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups the examples by package and entry-point name. This
allows us have a bazel build target for each group and also
allows us to separate MDC prototypes from standard implementations.