-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: group examples by package and entry-point name #16822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jelbourn
merged 2 commits into
angular:master
from
devversion:build/restructure-examples
Aug 20, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package(default_visibility = ["//visibility:public"]) | ||
|
||
load("//tools:defaults.bzl", "ng_module") | ||
|
||
ng_module( | ||
name = "a11y", | ||
srcs = glob(["**/*.ts"]), | ||
assets = glob([ | ||
"**/*.html", | ||
"**/*.css", | ||
]), | ||
deps = [ | ||
"//src/cdk/a11y", | ||
"//src/material/select", | ||
], | ||
) | ||
|
||
filegroup( | ||
name = "source-files", | ||
srcs = glob([ | ||
"*/*.html", | ||
"*/*.css", | ||
"*/*.ts", | ||
]), | ||
) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import {A11yModule} from '@angular/cdk/a11y'; | ||
import {NgModule} from '@angular/core'; | ||
import {MatSelectModule} from '@angular/material/select'; | ||
import { | ||
FocusMonitorDirectivesExample | ||
} from './focus-monitor-directives/focus-monitor-directives-example'; | ||
import { | ||
FocusMonitorFocusViaExample | ||
} from './focus-monitor-focus-via/focus-monitor-focus-via-example'; | ||
import {FocusMonitorOverviewExample} from './focus-monitor-overview/focus-monitor-overview-example'; | ||
|
||
const EXAMPLES = [ | ||
FocusMonitorDirectivesExample, | ||
FocusMonitorFocusViaExample, | ||
FocusMonitorOverviewExample, | ||
]; | ||
|
||
@NgModule({ | ||
imports: [ | ||
A11yModule, | ||
MatSelectModule, | ||
], | ||
declarations: EXAMPLES, | ||
exports: EXAMPLES, | ||
}) | ||
export class CdkA11yExamplesModule { | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package(default_visibility = ["//visibility:public"]) | ||
|
||
load("//tools:defaults.bzl", "ng_module") | ||
|
||
ng_module( | ||
name = "drag-drop", | ||
srcs = glob(["**/*.ts"]), | ||
assets = glob([ | ||
"**/*.html", | ||
"**/*.css", | ||
]), | ||
deps = [ | ||
"//src/cdk/drag-drop", | ||
"//src/cdk/overlay", | ||
"//src/cdk/portal", | ||
], | ||
) | ||
|
||
filegroup( | ||
name = "source-files", | ||
srcs = glob([ | ||
"*/*.html", | ||
"*/*.css", | ||
"*/*.ts", | ||
]), | ||
) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
import {DragDropModule} from '@angular/cdk/drag-drop'; | ||
import {OverlayModule} from '@angular/cdk/overlay'; | ||
import {CommonModule} from '@angular/common'; | ||
import {NgModule} from '@angular/core'; | ||
import { | ||
CdkDragDropAxisLockExample | ||
} from './cdk-drag-drop-axis-lock/cdk-drag-drop-axis-lock-example'; | ||
import {CdkDragDropBoundaryExample} from './cdk-drag-drop-boundary/cdk-drag-drop-boundary-example'; | ||
import { | ||
CdkDragDropConnectedSortingGroupExample | ||
} from './cdk-drag-drop-connected-sorting-group/cdk-drag-drop-connected-sorting-group-example'; | ||
import { | ||
CdkDragDropConnectedSortingExample | ||
} from './cdk-drag-drop-connected-sorting/cdk-drag-drop-connected-sorting-example'; | ||
import { | ||
CdkDragDropCustomPlaceholderExample | ||
} from './cdk-drag-drop-custom-placeholder/cdk-drag-drop-custom-placeholder-example'; | ||
import { | ||
CdkDragDropCustomPreviewExample | ||
} from './cdk-drag-drop-custom-preview/cdk-drag-drop-custom-preview-example'; | ||
import {CdkDragDropDelayExample} from './cdk-drag-drop-delay/cdk-drag-drop-delay-example'; | ||
import { | ||
CdkDragDropDisabledSortingExample | ||
} from './cdk-drag-drop-disabled-sorting/cdk-drag-drop-disabled-sorting-example'; | ||
import {CdkDragDropDisabledExample} from './cdk-drag-drop-disabled/cdk-drag-drop-disabled-example'; | ||
import { | ||
CdkDragDropEnterPredicateExample | ||
} from './cdk-drag-drop-enter-predicate/cdk-drag-drop-enter-predicate-example'; | ||
import { | ||
CdkDragDropFreeDragPositionExample | ||
} from './cdk-drag-drop-free-drag-position/cdk-drag-drop-free-drag-position-example'; | ||
import {CdkDragDropHandleExample} from './cdk-drag-drop-handle/cdk-drag-drop-handle-example'; | ||
import { | ||
CdkDragDropHorizontalSortingExample | ||
} from './cdk-drag-drop-horizontal-sorting/cdk-drag-drop-horizontal-sorting-example'; | ||
import {CdkDragDropOverviewExample} from './cdk-drag-drop-overview/cdk-drag-drop-overview-example'; | ||
import { | ||
CdkDragDropRootElementExample | ||
} from './cdk-drag-drop-root-element/cdk-drag-drop-root-element-example'; | ||
import {CdkDragDropSortingExample} from './cdk-drag-drop-sorting/cdk-drag-drop-sorting-example'; | ||
|
||
const EXAMPLES = [ | ||
CdkDragDropAxisLockExample, | ||
CdkDragDropBoundaryExample, | ||
CdkDragDropConnectedSortingExample, | ||
CdkDragDropConnectedSortingGroupExample, | ||
CdkDragDropCustomPlaceholderExample, | ||
CdkDragDropCustomPreviewExample, | ||
CdkDragDropDelayExample, | ||
CdkDragDropDisabledExample, | ||
CdkDragDropDisabledSortingExample, | ||
CdkDragDropEnterPredicateExample, | ||
CdkDragDropFreeDragPositionExample, | ||
CdkDragDropHandleExample, | ||
CdkDragDropHorizontalSortingExample, | ||
CdkDragDropOverviewExample, | ||
CdkDragDropRootElementExample, | ||
CdkDragDropSortingExample, | ||
]; | ||
|
||
@NgModule({ | ||
imports: [ | ||
DragDropModule, | ||
OverlayModule, | ||
CommonModule, | ||
], | ||
declarations: EXAMPLES, | ||
exports: EXAMPLES, | ||
}) | ||
export class CdkDragDropExamplesModule { | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package(default_visibility = ["//visibility:public"]) | ||
|
||
load("//tools:defaults.bzl", "ng_module") | ||
|
||
ng_module( | ||
name = "platform", | ||
srcs = glob(["**/*.ts"]), | ||
assets = glob([ | ||
"**/*.html", | ||
"**/*.css", | ||
]), | ||
deps = [ | ||
"//src/cdk/platform", | ||
], | ||
) | ||
|
||
filegroup( | ||
name = "source-files", | ||
srcs = glob([ | ||
"*/*.html", | ||
"*/*.css", | ||
"*/*.ts", | ||
]), | ||
) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import {PlatformModule} from '@angular/cdk/platform'; | ||
import {NgModule} from '@angular/core'; | ||
import {CdkPlatformOverviewExample} from './cdk-platform-overview/cdk-platform-overview-example'; | ||
|
||
const EXAMPLES = [CdkPlatformOverviewExample]; | ||
|
||
@NgModule({ | ||
imports: [ | ||
PlatformModule, | ||
], | ||
declarations: EXAMPLES, | ||
exports: EXAMPLES, | ||
}) | ||
export class CdkPlatformExamplesModule { | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package(default_visibility = ["//visibility:public"]) | ||
|
||
load("//tools:defaults.bzl", "ng_module") | ||
|
||
ng_module( | ||
name = "popover-edit", | ||
srcs = glob(["**/*.ts"]), | ||
assets = glob([ | ||
"**/*.html", | ||
"**/*.css", | ||
]), | ||
deps = [ | ||
"//src/cdk-experimental/popover-edit", | ||
"//src/cdk/collections", | ||
"//src/cdk/table", | ||
"@npm//@angular/forms", | ||
], | ||
) | ||
|
||
filegroup( | ||
name = "source-files", | ||
srcs = glob([ | ||
"*/*.html", | ||
"*/*.css", | ||
"*/*.ts", | ||
]), | ||
) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import {CdkPopoverEditModule} from '@angular/cdk-experimental/popover-edit'; | ||
import {CdkTableModule} from '@angular/cdk/table'; | ||
import {CommonModule} from '@angular/common'; | ||
import {NgModule} from '@angular/core'; | ||
import {FormsModule} from '@angular/forms'; | ||
import { | ||
CdkPopoverEditCdkTableFlexExample | ||
} from './cdk-popover-edit-cdk-table-flex/cdk-popover-edit-cdk-table-flex-example'; | ||
import { | ||
CdkPopoverEditCdkTableExample | ||
} from './cdk-popover-edit-cdk-table/cdk-popover-edit-cdk-table-example'; | ||
import { | ||
CdkPopoverEditCellSpanVanillaTableExample | ||
} from | ||
'./cdk-popover-edit-cell-span-vanilla-table/cdk-popover-edit-cell-span-vanilla-table-example'; | ||
import { | ||
CdkPopoverEditTabOutVanillaTableExample | ||
} from './cdk-popover-edit-tab-out-vanilla-table/cdk-popover-edit-tab-out-vanilla-table-example'; | ||
import { | ||
CdkPopoverEditVanillaTableExample | ||
} from './cdk-popover-edit-vanilla-table/cdk-popover-edit-vanilla-table-example'; | ||
|
||
const EXAMPLES = [ | ||
CdkPopoverEditCdkTableExample, | ||
CdkPopoverEditCdkTableFlexExample, | ||
CdkPopoverEditCellSpanVanillaTableExample, | ||
CdkPopoverEditTabOutVanillaTableExample, | ||
CdkPopoverEditVanillaTableExample, | ||
]; | ||
|
||
@NgModule({ | ||
imports: [ | ||
CdkPopoverEditModule, | ||
CdkTableModule, | ||
FormsModule, | ||
CommonModule, | ||
], | ||
declarations: EXAMPLES, | ||
exports: EXAMPLES, | ||
}) | ||
export class CdkPopoverEditExamplesModule { | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a follow-up, we should probably split this is into
src/material-examples
andsrc/cdk-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that was one of the ideas when I made separate directories 😄 It just involves a bit more work for now since our docs only expect one examples package right now.