build: use bazel automatic execution strategy selection #16823
Conversation
googlebot
added
the
cla: yes
devversion
changed the title
* Switches our bazel setup to use the new bazel automatic strategy selection.
Currenlty all `ts_library`'s using the test tsconfig file are not hermetic and will break when running remotely. This is because just `tsconfig-test.json` is referenced as action input while the tsconfig actually extends from the `tsconfig-build.json`.
devversion
force-pushed
the
build/leverage-new-bazel-automatic-strategy-selection
branch
from
d076715 to
1663383
Compare
devversion
force-pushed
the
build/leverage-new-bazel-automatic-strategy-selection
branch
from
d8bd402 to
1663383
Compare
devversion
added
pr: merge safe
target: patch
|
@devversion it is an issue on the Bazel side. I am trying to understand the priority of this issue. Can you quantify the overhead? |
|
@buchgr This PR was originally just changing some things on the execution strategy, but I also spent some time looking into CI performance with Bazel. Apparently some of the jobs we have, always seem to build the runfile trees even though they are not needed/the test results are cached. Your thoughts on the bazel issue seemed to confirm my thoughts that the situation could be improved on the bazel side by not building the runfile trees in remote, or if results are cached. If you for example look at a CI job where nothing really changed any action input, Bazel still seems to build the runfile trees: https://circleci.com/gh/angular/components/72208. Since we have a lot of test targets (~46) it seems like a lot of unnecessary runfile tree's are created. Preferably since nothing changed, the CI job should run as a noop. I'm not sure if I can give any specific numbers (yet), but it looks like it definitely takes up some time. Especially in the Bazel & NodeJS story where actions require a lot of runfiles (causing a lot of files to be transferred/symlinked). Happy to chat more about this if you think it's helpful. |
jelbourn
added
pr: lgtm
action: merge
Currenlty all `ts_library`'s using the test tsconfig file are not hermetic and will break when running remotely. This is because just `tsconfig-test.json` is referenced as action input while the tsconfig actually extends from the `tsconfig-build.json`. (cherry picked from commit c05d57f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Related to CI performance with Bazel: We currently get a lot of overhead for actions not running on remote as they cause runfile tree's to be created even though we don't need these (as test results are cached / or we just build). This seems like a bug/issue on the bazel-side: bazelbuild/bazel#6627