Skip to content

build: disable runfile creation in bazel_build job #16824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

@devversion devversion commented Aug 20, 2019

Disables runfile tree creation in the bazel_build job. The runfile trees
are only needed for execution of test/binary targets, but this is not the
case for the bazel_build job. Runfile trees are not cached and therefore
cause the job to not fully leverage remote caching.

For testing jobs we still get the overhead of creating runfile tree's even if
the test results were part of the remote cache. Seems like a bug/issue that
is tracked on the bazel side: bazelbuild/bazel#6627

Disables runfile tree creation in the `bazel_build` job. The runfile trees
are only needed for execution of test/binary targets, but this is not the
case for the `bazel_build` job. Runfile trees are not cached and therefore
cause the job to not fully leverage remote caching.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 20, 2019
@devversion
Copy link
Member Author

Moving that into #16823 if possible. Looks like a few targets that aren't executed on remote still need runfile tree's to build action output.

@devversion devversion closed this Aug 20, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants