build: fix bazel devserver not launching #17160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom devserver implementation does currently not work due to a breaking change in the `rules_nodejs` repo. Apparently a `nodejs_binary` no longer generates an executable output without either `.bat` or `.sh`. This is something we relied on in the devserver launcher script. The fix is as simple as resolving the executable with `.sh` extension as we run the devserver launcher from within a `sh_binary` already.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
The custom devserver implementation does currently not work due to a breaking change in the `rules_nodejs` repo. Apparently a `nodejs_binary` no longer generates an executable output without either `.bat` or `.sh`. This is something we relied on in the devserver launcher script. The fix is as simple as resolving the executable with `.sh` extension as we run the devserver launcher from within a `sh_binary` already. (cherry picked from commit 7f6972f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom devserver implementation does currently not
work due to a breaking change in the
rules_nodejsrepo.Apparently a
nodejs_binaryno longer generates an executableoutput without either
.bator.sh. This is something werelied on in the devserver launcher script. The fix is as simple
as resolving the executable with
.shextension as we run thedevserver launcher from within a
sh_binaryalready.