Skip to content

build: fix bazel devserver not launching #17160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019
Merged

build: fix bazel devserver not launching #17160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tools/dev-server/launcher_template.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@ if [[ ! -z "RUNFILES_DIR" ]]; then
export RUNFILES_MANIFEST_ONLY="1"
fi

# Resolve the path of the dev-server binary.
devserverBin=$(rlocation "angular_material/tools/dev-server/dev-server_bin")
# Resolve the path of the dev-server binary. Note: usually we either need to
# resolve the "nodejs_binary" executable with different file extensions on
# windows, but since we already run this launcher as part of a "sh_binary", we
# can safely execute another shell script from the current shell.
devserverBin=$(rlocation "angular_material/tools/dev-server/dev-server_bin.sh")

# Start the devserver with the given arguments. The arguments will be
# substituted based on the rule attributes.
Expand Down