Skip to content

docs(v9-hammerjs-migration): fixes and refinements #18107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

docs(v9-hammerjs-migration): fixes and refinements #18107

merged 1 commit into from
Jan 30, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jan 6, 2020 •
edited
Loading

Minor tweaks and a fix for a grammar issue in the guide created in PR #17769.

@Splaktar Splaktar added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation target: major This PR is targeted for the next major release labels Jan 6, 2020
@Splaktar Splaktar added this to the 9.0.0 milestone Jan 6, 2020
@Splaktar Splaktar requested a review from devversion January 6, 2020 00:59
@Splaktar Splaktar requested a review from jelbourn as a code owner January 6, 2020 00:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 6, 2020
devversion
devversion approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FWIW: I tried matching the pattern (in regards to the use of "your") we use in the
new angular.io migration guides (example)

@Splaktar
Copy link
Contributor Author

Splaktar commented Jan 9, 2020

I agree that angular.io uses a lot of you/your (I had checked that prior to making these changes), so I don't think that is a problem. It was just about being consistent all the way through the doc.

@jelbourn
Copy link
Member

I think the docs were better without this change because this introduces passive voice. I think the use of "your" in the current form is fine.

@jelbourn jelbourn removed this from the 9.0.0 milestone Jan 28, 2020
@jelbourn jelbourn removed the pr: lgtm label Jan 28, 2020
@Splaktar Splaktar removed the target: major This PR is targeted for the next major release label Jan 30, 2020
@Splaktar Splaktar force-pushed the tweak-hammerjs-migration-doc branch from 22b4b0e to ffa4326 Compare January 30, 2020 15:14
@Splaktar Splaktar self-assigned this Jan 30, 2020
@Splaktar Splaktar added the target: major This PR is targeted for the next major release label Jan 30, 2020
@Splaktar
Copy link
Contributor Author

@jelbourn this has been updated based on your feedback. Please review for v9 as there are still some typos and other fixes beyond just "the vs your".

devversion
devversion reviewed Jan 30, 2020
View reviewed changes
@Splaktar Splaktar force-pushed the tweak-hammerjs-migration-doc branch 3 times, most recently from 5c9a3da to 1f91285 Compare January 30, 2020 19:20
@Splaktar Splaktar force-pushed the tweak-hammerjs-migration-doc branch from 1f91285 to 4e913ad Compare January 30, 2020 19:22
devversion
devversion approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion assigned jelbourn and unassigned Splaktar Jan 30, 2020
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jan 30, 2020
@jelbourn jelbourn merged commit 8865e78 into master Jan 30, 2020
jelbourn pushed a commit that referenced this pull request Jan 30, 2020
@Splaktar @jelbourn
docs(v9-hammerjs-migration): fixes and refinements (#18107)
125cbd8 
(cherry picked from commit 8865e78)
@Splaktar Splaktar deleted the tweak-hammerjs-migration-doc branch January 30, 2020 19:35
yifange pushed a commit to yifange/components that referenced this pull request Feb 6, 2020
@Splaktar @yifange
docs(v9-hammerjs-migration): fixes and refinements (angular#18107)
1fa02da
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @jelbourn @devversion @googlebot