Skip to content

build: make built dev-app web package writable #18481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Bazel by default marks output files as readonly to ensure hermeticity.
Since we moved these files out of the bazel-bin directory, we should
make the files writable. This is necessary so that subsequent runs of this
script can delete the old distPath contents.

Bazel by default marks output files as `readonly` to ensure hermeticity.
Since we moved these files out of the `bazel-bin` directory, we should
make the files writable. This is necessary so that subsequent runs of this
script can delete the old `distPath` contents.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 12, 2020
@devversion devversion requested a review from a team as a code owner February 12, 2020 17:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 12, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 12, 2020
@ngbot
Copy link

ngbot bot commented Feb 12, 2020

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit ef30035 into angular:master Feb 12, 2020
mmalerba pushed a commit that referenced this pull request Feb 19, 2020
Bazel by default marks output files as `readonly` to ensure hermeticity.
Since we moved these files out of the `bazel-bin` directory, we should
make the files writable. This is necessary so that subsequent runs of this
script can delete the old `distPath` contents.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants