-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: make built dev-app web package writable #18481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make built dev-app web package writable #18481
Conversation
Bazel by default marks output files as `readonly` to ensure hermeticity. Since we moved these files out of the `bazel-bin` directory, we should make the files writable. This is necessary so that subsequent runs of this script can delete the old `distPath` contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bazel by default marks output files as `readonly` to ensure hermeticity. Since we moved these files out of the `bazel-bin` directory, we should make the files writable. This is necessary so that subsequent runs of this script can delete the old `distPath` contents.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bazel by default marks output files as
readonly
to ensure hermeticity.Since we moved these files out of the
bazel-bin
directory, we shouldmake the files writable. This is necessary so that subsequent runs of this
script can delete the old
distPath
contents.