Skip to content

build: make built dev-app web package writable #18481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

build: make built dev-app web package writable #18481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/deploy-dev-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* deployed to the currently configured Firebase project.
*/

const {exec, set, cd, cp, rm} = require('shelljs');
const {exec, set, cd, cp, rm, chmod} = require('shelljs');
const {join} = require('path');

// ShellJS should throw if any command fails.
Expand Down Expand Up @@ -37,5 +37,10 @@ rm('-Rf', distPath);
// of a public folder outside of the "firebase.json" file.
cp('-R', webPackagePath, distPath);

// Bazel by default marks output files as `readonly` to ensure hermeticity. Since we moved
// these files out of the `bazel-bin` directory, we should make them writable. This is necessary
// so that subsequent runs of this script can delete old contents from the deployment dist folder.
chmod('-R', 'u+w', distPath);

// Run the Firebase CLI to deploy the hosting target.
exec(`yarn -s firebase deploy --only hosting`);