Skip to content

build: update buildifier and fix failures #18997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 5, 2020

Our version of @bazel/buildifier is pretty old. These changes bump to the latest version and fix the new failures that showed up.

Our version of `@bazel/buildifier` is pretty old. These changes bump to the latest version and fix the new failures that showed up.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Apr 5, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 5, 2020
@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 6, 2020
@mmalerba mmalerba merged commit 8c3ba38 into angular:master Apr 6, 2020
mmalerba pushed a commit that referenced this pull request Apr 14, 2020
Our version of `@bazel/buildifier` is pretty old. These changes bump to the latest version and fix the new failures that showed up.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants