Skip to content

build: update buildifier and fix failures #18997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package(default_visibility = ["//visibility:public"])

load("//:rollup-globals.bzl", "ROLLUP_GLOBALS")
load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS")
load("//src/cdk-experimental:config.bzl", "CDK_EXPERIMENTAL_ENTRYPOINTS")
load("//src/material:config.bzl", "MATERIAL_ENTRYPOINTS", "MATERIAL_TESTING_ENTRYPOINTS")
load("//src/material-experimental:config.bzl", "MATERIAL_EXPERIMENTAL_ENTRYPOINTS", "MATERIAL_EXPERIMENTAL_TESTING_ENTRYPOINTS")

package(default_visibility = ["//visibility:public"])

exports_files([
"LICENSE",
"scss-bundle.config.json",
Expand Down
4 changes: 2 additions & 2 deletions guides/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "markdown_to_html")

package(default_visibility = ["//visibility:public"])

markdown_to_html(
name = "guides",
srcs = glob(["**/*.md"]),
Expand Down
4 changes: 2 additions & 2 deletions integration/ts-compat/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package(default_visibility = ["//visibility:public"])

load("@bazel_skylib//rules:write_file.bzl", "write_file")
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_test")
load("//integration/ts-compat:import-all-entry-points.bzl", "generate_import_all_entry_points_file")

package(default_visibility = ["//visibility:public"])

write_file(
name = "import-all-entry-points-file",
out = "import-all-entry-points.ts",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"@angular/platform-server": "^9.1.0",
"@angular/router": "^9.1.0",
"@bazel/bazelisk": "^1.3.0",
"@bazel/buildifier": "^0.29.0",
"@bazel/buildifier": "^2.2.1",
"@bazel/ibazel": "^0.12.3",
"@bazel/jasmine": "^1.5.0",
"@bazel/karma": "^1.5.0",
Expand Down
4 changes: 2 additions & 2 deletions src/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package(default_visibility = ["//visibility:public"])

load("@npm_bazel_typescript//:index.bzl", "ts_config")
load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS")
load("//src/material:config.bzl", "MATERIAL_ENTRYPOINTS", "MATERIAL_TESTING_ENTRYPOINTS")
load("//tools/dgeni:index.bzl", "dgeni_api_docs")

package(default_visibility = ["//visibility:public"])

cdkApiEntryPoints = CDK_ENTRYPOINTS

materialApiEntryPoints = MATERIAL_ENTRYPOINTS + MATERIAL_TESTING_ENTRYPOINTS
Expand Down
4 changes: 2 additions & 2 deletions src/cdk-experimental/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package(default_visibility = ["//visibility:public"])

load("//src/cdk-experimental:config.bzl", "CDK_EXPERIMENTAL_TARGETS")
load("//tools:defaults.bzl", "ng_package", "ts_library")

package(default_visibility = ["//visibility:public"])

ts_library(
name = "cdk-experimental",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk-experimental/column-resize/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ng_module")

package(default_visibility = ["//visibility:public"])

ng_module(
name = "column-resize",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk-experimental/dialog/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite", "sass_binary")

package(default_visibility = ["//visibility:public"])

ng_module(
name = "dialog",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk-experimental/popover-edit/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")

package(default_visibility = ["//visibility:public"])

ng_module(
name = "popover-edit",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk-experimental/scrolling/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package(default_visibility = ["//visibility:public"])

load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite")

package(default_visibility = ["//visibility:public"])

ng_module(
name = "scrolling",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package(default_visibility = ["//visibility:public"])

load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS", "CDK_ENTRYPOINTS_WITH_STYLES", "CDK_SCSS_LIBS", "CDK_TARGETS")
load("//tools:defaults.bzl", "ng_package", "ts_library")

package(default_visibility = ["//visibility:public"])

ts_library(
name = "cdk",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/a11y/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -10,6 +8,8 @@ load(
"sass_library",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "a11y",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/accordion/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "accordion",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/bidi/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "bidi",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/clipboard/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "markdown_to_html", "ng_module", "ng_test_library", "ng_web_test_suite")

package(default_visibility = ["//visibility:public"])

ng_module(
name = "clipboard",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/coercion/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ts_library")

package(default_visibility = ["//visibility:public"])

ts_library(
name = "coercion",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/collections/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "collections",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/drag-drop/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "drag-drop",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/keycodes/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ng_module", "ts_library")

package(default_visibility = ["//visibility:public"])

# We need to use "ng_module" here since we want metadata to be generated for keycode
# constants. This is necessary because some of these constants are statically used in
# component/directive metadata (e.g. chips) and NGC needs to be able to evaluate these
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/layout/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "layout",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/observers/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "observers",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/overlay/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
load(
"//tools:defaults.bzl",
Expand All @@ -12,6 +10,8 @@ load(
"sass_library",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "overlay",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/platform/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "markdown_to_html", "ng_module")

package(default_visibility = ["//visibility:public"])

ng_module(
name = "platform",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/portal/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "portal",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/schematics/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package(default_visibility = ["//visibility:public"])

load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
load("//:packages.bzl", "VERSION_PLACEHOLDER_REPLACEMENTS")
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

package(default_visibility = ["//visibility:public"])

filegroup(
name = "schematics_assets",
srcs = glob([
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/schematics/testing/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ts_library")

package(default_visibility = ["//visibility:public"])

ts_library(
name = "testing",
srcs = glob(["**/*.ts"]),
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/schematics/update-tool/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ts_library")

package(default_visibility = ["//visibility:public"])

ts_library(
name = "update-tool",
srcs = glob(["**/*.ts"]),
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/scrolling/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -9,6 +7,8 @@ load(
"sass_binary",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "scrolling",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/stepper/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "markdown_to_html", "ng_module")

package(default_visibility = ["//visibility:public"])

ng_module(
name = "stepper",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/table/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
package(default_visibility = ["//visibility:public"])

load(
"//tools:defaults.bzl",
"markdown_to_html",
Expand All @@ -8,6 +6,8 @@ load(
"ng_web_test_suite",
)

package(default_visibility = ["//visibility:public"])

ng_module(
name = "table",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/testing/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package(default_visibility = ["//visibility:public"])

load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
load("//tools:defaults.bzl", "markdown_to_html", "ng_web_test_suite", "ts_library")

package(default_visibility = ["//visibility:public"])

ts_library(
name = "testing",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/testing/private/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ts_library")

package(default_visibility = ["//visibility:public"])

ts_library(
name = "private",
srcs = glob(
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/testing/private/e2e/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load("//tools:defaults.bzl", "ng_e2e_test_library")

package(default_visibility = ["//visibility:public"])

exports_files(["tsconfig-e2e.json"])

ng_e2e_test_library(
Expand Down
Loading