refactor: decouple migrations from CLI devkit #19004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
migrations-g3
branch
5 times, most recently
from
ff4b390 to
7e74aa6
Compare
We want to refactor our update-tool to no longer rely on specifics from the Angular CLI devkit. This has various benefits: * Ability to run migrations inside Google. * Ability to run migrations in a standalone tool (for people not using the CLI!) * No tight dependency on the CLI devkit API. We could easily switch tools if needed. * Ability to wrap migrations in tslint rules (or other tools). * And potentially more. These are just the ones that came to mind yet.
devversion
force-pushed
the
migrations-g3
branch
from
7e74aa6 to
168b2c1
Compare
andrewseguin
approved these changes
Apr 6, 2020
|
@andrewseguin Thanks for reviewing! Yeah I guess we could do that for testing. The migrations (except for the HammerJS one) should be compatible. The HammerJS one heavily relies on the CLI workspace config etc. |
devversion
added a commit
that referenced
this pull request
Apr 24, 2020
We want to refactor our update-tool to no longer rely on specifics from the Angular CLI devkit. This has various benefits: * Ability to run migrations inside Google. * Ability to run migrations in a standalone tool (for people not using the CLI!) * No tight dependency on the CLI devkit API. We could easily switch tools if needed. * Ability to wrap migrations in tslint rules (or other tools). * And potentially more. These are just the ones that came to mind yet.
devversion
added a commit
that referenced
this pull request
Apr 24, 2020
We want to refactor our update-tool to no longer rely on specifics from the Angular CLI devkit. This has various benefits: * Ability to run migrations inside Google. * Ability to run migrations in a standalone tool (for people not using the CLI!) * No tight dependency on the CLI devkit API. We could easily switch tools if needed. * Ability to wrap migrations in tslint rules (or other tools). * And potentially more. These are just the ones that came to mind yet.
jelbourn
pushed a commit
that referenced
this pull request
Apr 25, 2020
* refactor: decouple migrations from CLI devkit (#19004) We want to refactor our update-tool to no longer rely on specifics from the Angular CLI devkit. This has various benefits: * Ability to run migrations inside Google. * Ability to run migrations in a standalone tool (for people not using the CLI!) * No tight dependency on the CLI devkit API. We could easily switch tools if needed. * Ability to wrap migrations in tslint rules (or other tools). * And potentially more. These are just the ones that came to mind yet. * Address feedback
jelbourn
pushed a commit
that referenced
this pull request
Apr 25, 2020
* refactor: decouple migrations from CLI devkit (#19004) We want to refactor our update-tool to no longer rely on specifics from the Angular CLI devkit. This has various benefits: * Ability to run migrations inside Google. * Ability to run migrations in a standalone tool (for people not using the CLI!) * No tight dependency on the CLI devkit API. We could easily switch tools if needed. * Ability to wrap migrations in tslint rules (or other tools). * And potentially more. These are just the ones that came to mind yet. * Address feedback
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to refactor our update-tool to no longer rely
on specifics from the Angular CLI devkit. This has various benefits:
This will be the foundation for our MDC migrations that should run within CLI projects and inside Google. Optionally we can provide a standalone CLI tool that runs the migrations too!