-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor: decouple migrations from CLI devkit #19014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Regardless of whether we'll share the MDC migration code internally and externally, these changes can be useful to land in |
* for this has been removed and absolute manifest paths or the runfile helpers are now needed | ||
* on Windows. This helper provides a resolution method that works similar on all platforms. | ||
*/ | ||
export function resolveBazel(parent: string, relativePath: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolveBazelPath
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense to me.
// Imports the runfile helpers from the Bazel NodeJS rules. This should be ideally | ||
// a separate package with types. https://github.com/bazelbuild/rules_nodejs/issues/1793. | ||
// Note: We don't want to import this outside of this function as the runfile helpers are | ||
// quite large we don't want to load them for every import to `@angular/cdk/testing/private`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm starting to feel like we should keep a centralized list of all the bazel-related rough edges / workarounds we have in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agreed. Maybe we should move this stuff into tools/bazel
so that we can have a clear picture of what is specific to Bazel. We can do that as a follow-up if you think that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you; you're the one who ends up dealing with it the most, so whatever makes your life easier
2e64c8c
to
e8fec55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like there's a circular dep? |
We want to refactor our update-tool to no longer rely on specifics from the Angular CLI devkit. This has various benefits: * Ability to run migrations inside Google. * Ability to run migrations in a standalone tool (for people not using the CLI!) * No tight dependency on the CLI devkit API. We could easily switch tools if needed. * Ability to wrap migrations in tslint rules (or other tools). * And potentially more. These are just the ones that came to mind yet.
e8fec55
to
ff00b4e
Compare
Yeah, should be fixed now. |
* refactor: decouple migrations from CLI devkit (#19004) We want to refactor our update-tool to no longer rely on specifics from the Angular CLI devkit. This has various benefits: * Ability to run migrations inside Google. * Ability to run migrations in a standalone tool (for people not using the CLI!) * No tight dependency on the CLI devkit API. We could easily switch tools if needed. * Ability to wrap migrations in tslint rules (or other tools). * And potentially more. These are just the ones that came to mind yet. * Address feedback
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We want to refactor our update-tool to no longer rely
on specifics from the Angular CLI devkit. This has various benefits:
Additionally, this PR fixes an issue with Bazel on Windows where runfiles no longer can be resolved. This is because
rules_nodejs
symlinks the workspace into the@npm
repository now, and resolving runfiles through relative paths no longer works.