refactor: add virtual scroll repeater interface #19570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelJamesParsons
requested review from
andrewseguin and
crisbeto
as code owners
googlebot
added
the
cla: yes
MichaelJamesParsons
force-pushed
the
virtual-scroll-repeater
branch
from
bf3cb90 to
4588870
Compare
MichaelJamesParsons
force-pushed
the
virtual-scroll-repeater
branch
from
4588870 to
2ca7a01
Compare
|
@mmalerba PTAL |
|
@MichaelJamesParsons looks like there's some failing lints - otherwise looks good |
mmalerba
added
P2
MichaelJamesParsons
force-pushed
the
virtual-scroll-repeater
branch
from
2ca7a01 to
7775bf0
Compare
|
sg. Golden checks are now passing |
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally refactored
virtualForOfinto an interface as part of some ongoing virtual scroll enhancements. After discovering #16412, I decided to use the existing work since it has already been blessed. Prior attempts to merge this change in #14287 and #16412 have gone stale without any recent updates, so I forked the changes and fixed file conflicts.