build: enable more strictness flags in non-library code #23077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
added
merge safe
P3
devversion
approved these changes
Jun 29, 2021
| @@ -23,23 +23,23 @@ export class AttributeSelectorsMigration extends Migration<UpgradeData> { | |||
| data = getVersionUpgradeData(this, 'attributeSelectors'); | |||
|
|
|||
| // Only enable the migration rule if there is upgrade data. | |||
| enabled = this.data.length !== 0; | |||
| enabled: boolean = this.data.length !== 0; | |||
There was a problem hiding this comment.
I wonder why this is needed. Seems like something TS could infer quite easily?
There was a problem hiding this comment.
It's a weird one, but for some reason TS was flagging the entire class if the type isn't specified explicitly. It was something about not being able to infer the type from the constructor.
Updates the compiler options for the schematics and other Node-based code, and resolves any compilation errors that showed up as a result. Also fixes a bunch of references to non-existent types from `parse5`.
crisbeto
force-pushed
the
tools-implicit-overrides
branch
from
d55cb63 to
f76ddaa
Compare
amysorto
pushed a commit
that referenced
this pull request
Jun 29, 2021
Updates the compiler options for the schematics and other Node-based code, and resolves any compilation errors that showed up as a result. Also fixes a bunch of references to non-existent types from `parse5`. (cherry picked from commit 7b3006f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the compiler options for the schematics and other Node-based code, and resolves any compilation errors that showed up as a result. Also fixes a bunch of references to non-existent types from
parse5.