refactor(multiple): enable noImplicitOverride typescript option (#22830)
#23091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gular#22830) * refactor(multiple): enable `noImplicitOverride` typescript option Enables the TypeScript `noImplicitOverride` option and adds the `override` keyword where needed. * build: add yarn script alias for tsc Adds a `yarn run` alias for the `tsc` binary. Since we have multiple versions of TypeScript installed, Yarn can pick another version (e.g. from `typescript-4.2`) for linking the `tsc` binary. This is unexpected because `yarn tsc` should resolve to the TypeScript version that is not installed through a Yarn alias. Changing the order in the Yarn lock file does not help, and it seems expected in the context of Yarn which does not know which package (regardless of alias or not) to prefer.
amysorto
requested review from
andrewseguin,
crisbeto,
jelbourn and
a team
as code owners
This comment has been minimized.
This comment has been minimized.
google-cla
bot
added
the
cla: no
…satisfy noImplicitOverride (angular#23017) Given we merged the `noImplicitOverride` PR together with a couple of other PRs, new methods could have been introduced that did not use the `override` keyword. This is the case for the MDC tooltip `_onShow` method. This commit adds the necessary `override` keyword.
This comment has been minimized.
This comment has been minimized.
devversion
approved these changes
Jun 29, 2021
|
@googlebot I consent. |
google-cla
bot
added
cla: yes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noImplicitOverridetypescript optionEnables the TypeScript
noImplicitOverrideoption and addsthe
overridekeyword where needed.Adds a
yarn runalias for thetscbinary. Since we havemultiple versions of TypeScript installed, Yarn can pick
another version (e.g. from
typescript-4.2) for linkingthe
tscbinary. This is unexpected becauseyarn tscshouldresolve to the TypeScript version that is not installed through
a Yarn alias. Changing the order in the Yarn lock file does not
help, and it seems expected in the context of Yarn which does not
know which package (regardless of alias or not) to prefer.