fix: input coercion #23148
Closed
fix: input coercion #23148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekhmanrus
requested review from
andrewseguin,
crisbeto,
devversion,
jelbourn and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Jul 13, 2021
lekhmanrus
force-pushed
the
coercion-fixes
branch
from
e92a99f to
945baef
Compare
|
@crisbeto is there anything I can do? |
|
As I mentioned above, we'd have to measure how much of an effect this has on bundle sizes. I also expect this to conflict with #23606. |
lekhmanrus
force-pushed
the
coercion-fixes
branch
from
945baef to
af729b3
Compare
|
I'm not sure what command should I run to measure it. I used cdk/drag-drop/all-directives: 155979
cdk/drag-drop/basic: 153337
-material-experimental/mdc-chips/basic: 188774
+material-experimental/mdc-chips/basic: 189051
-material-experimental/mdc-form-field/advanced: 222655
+material-experimental/mdc-form-field/advanced: 222932
-material-experimental/mdc-form-field/basic: 221144
+material-experimental/mdc-form-field/basic: 221421
-material/autocomplete/without-optgroup: 208957
+material/autocomplete/without-optgroup: 209400
-material/button-toggle/standalone: 120880
+material/button-toggle/standalone: 121327
-material/chips/basic: 163503
+material/chips/basic: 163506
-material/datepicker/range-picker/without-form-field: 327676
+material/datepicker/range-picker/without-form-field: 328217
material/expansion/without-accordion: 134600
material/form-field/advanced: 181564
material/form-field/basic: 179979
-material/list/nav-list: 128581
+material/list/nav-list: 128949
-material/menu/without-lazy-content: 214482
+material/menu/without-lazy-content: 214941
-material/radio/without-group: 124015
+material/radio/without-group: 124287
-material/select/basic: 256683
+material/select/basic: 257287
-material/tabs/advanced: 183425
+material/tabs/advanced: 183988
-material/tabs/basic: 182564
+material/tabs/basic: 183127 |
lekhmanrus
force-pushed
the
coercion-fixes
branch
3 times, most recently
from
dc77515 to
bd688fb
Compare
lekhmanrus
force-pushed
the
coercion-fixes
branch
from
bd688fb to
250fe02
Compare
andrewseguin
removed
the
cla: yes
googlebot
added
the
cla: yes
|
@crisbeto Despite adding to the code size, it does seem like we should have had these from the beginning. Should we request the author to rebase? |
andrewseguin
added
the
needs: clarification
josephperrott
added
action: cleanup
|
Closing since this PR hasn't been touched in a long time and it has a lot of conflicts. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied missed boolean/number coercion for
@Input's.