Skip to content

refactor(multiple): remove coercion members #23606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 20, 2021

  • Drops support for TypeScript 4.2. There's a PR that does this already on the Framework side: feat(core): support TypeScript 4.4 angular#43281.
  • Replaces all usages of the ngAcceptInputType members with type declarations directly on the setters.
  • Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added.

Note: setting this as a P2, because it's prone to merge conflicts.

* Drops support for TypeScript 4.2. There's a PR that does this already on the Framework side: angular/angular#43281.
* Replaces all usages of the `ngAcceptInputType` members with type declarations directly on the setters.
* Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2021
@crisbeto crisbeto marked this pull request as ready for review September 20, 2021 18:03
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Sep 20, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Sep 20, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Caretaker note: raise any failures for this for discussion so we can figure out how to resolve them quickly

@jelbourn jelbourn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker labels Sep 20, 2021
@crisbeto crisbeto mentioned this pull request Sep 21, 2021
@wagnermaciel
Copy link
Contributor

@crisbeto This has a lot of internal errors because the types of getters and setters don't match.

Here's an example.

focus-trap.ts:398:6: ERROR - The types of the getter and setter for property 'enabled' do not match.
getter type is: boolean
setter type is: (boolean|null|string|undefined)

@crisbeto
Copy link
Member Author

It sounds like g3 is running on TypeScript 4.2 which doesn't support different types for getters and setters. @jelbourn do you know if there's a plan to move to 4.3?

@jelbourn
Copy link
Member

Yeah, AFAIK that work is actively in progress.

@devversion devversion removed their request for review September 22, 2021 17:25
@crisbeto crisbeto added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Sep 30, 2021
@wagnermaciel
Copy link
Contributor

@crisbeto Should we remove the merge ready label from this pr since it is blocked?

@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Oct 27, 2021
@crisbeto
Copy link
Member Author

Removing the label. @amysorto do you happen to have a link to the Closure bug?

@amysorto
Copy link
Contributor

@crisbeto b/201080911

@crisbeto
Copy link
Member Author

crisbeto commented Dec 4, 2021

Closing in favor of #24055.

@crisbeto crisbeto closed this Dec 4, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked This issue is blocked by some external factor, such as a prerequisite PR cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants