-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(multiple): remove coercion members #23606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Drops support for TypeScript 4.2. There's a PR that does this already on the Framework side: angular/angular#43281. * Replaces all usages of the `ngAcceptInputType` members with type declarations directly on the setters. * Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Caretaker note: raise any failures for this for discussion so we can figure out how to resolve them quickly
@crisbeto This has a lot of internal errors because the types of getters and setters don't match. Here's an example.
|
It sounds like g3 is running on TypeScript 4.2 which doesn't support different types for getters and setters. @jelbourn do you know if there's a plan to move to 4.3? |
Yeah, AFAIK that work is actively in progress. |
@crisbeto Should we remove the merge ready label from this pr since it is blocked? |
Removing the label. @amysorto do you happen to have a link to the Closure bug? |
Closing in favor of #24055. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ngAcceptInputType
members with type declarations directly on the setters.Note: setting this as a P2, because it's prone to merge conflicts.