fix(material/input): show required asterisk when using required validator #23362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
…ator Resolves the long-standing issue where the required asterisk wasn't being shown in the form field label when using the `required` validator from Forms. Fixes angular#2574.
crisbeto
force-pushed
the
2574/required-asterisk
branch
from
b7c69a8 to
4b588d1
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 16, 2021
…ator Similar to angular#23362. Fixes that the required asterisk wasn't being shown when a chip list is required.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 16, 2021
…ator Similar to angular#23362. Fixes that the required asterisk wasn't being shown when a chip list is required.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 31, 2021
…dator Similar to angular#23362. Fixes that the required asterisk wasn't being shown when a select is required.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 31, 2021
…dator Similar to angular#23362. Fixes that the required asterisk wasn't being shown when a select is required.
crisbeto
added
target: rc
|
This is a breaking change incompatible with the material spec. No asterisk probably should have been the default https://material.io/components/text-fields#:~:text=Required%20text%20indicator |
|
This change is primarily for consistency. Before it, you'd get the asterisk with |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the long-standing issue where the required asterisk wasn't being shown in the form field label when using the
requiredvalidator from Forms.Note: these changes target v13, because the
hasValidatorAPI was introduced in 12.2.0.Fixes #2574.