fix(material/select): show required asterisk when using required validator #23500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
…dator Similar to angular#23362. Fixes that the required asterisk wasn't being shown when a select is required.
crisbeto
force-pushed
the
select-required-asterisk
branch
from
b2671d1 to
5df0079
Compare
jelbourn
reviewed
Sep 3, 2021
| @@ -317,12 +323,14 @@ export abstract class _MatSelectBase<C> extends _MatSelectMixinBase implements A | |||
|
|
|||
| /** Whether the component is required. */ | |||
| @Input() | |||
| get required(): boolean { return this._required; } | |||
| get required(): boolean { | |||
| return this._required ?? this.ngControl?.control?.hasValidator(Validators.required) ?? false; | |||
There was a problem hiding this comment.
Should this also have a test for explicitly setting required overriding the form control required state?
There was a problem hiding this comment.
The forms module will log a deprecation warning if required is used on an element with formControl.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #23362. Fixes that the required asterisk wasn't being shown when a select is required.