Skip to content

build: reduce jelbourn presence in code owners #24083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Dec 9, 2021

Updating this to shuffle more code reviews from myself to @andrewseguin

@jelbourn jelbourn added merge safe target: patch This PR is targeted for the next patch release labels Dec 9, 2021
@jelbourn jelbourn requested a review from andrewseguin December 9, 2021 22:13
@jelbourn jelbourn requested a review from a team as a code owner December 9, 2021 22:13
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -124,12 +124,12 @@
/src/material-experimental/mdc-table/** @andrewseguin
/src/material-experimental/mdc-theming/** @mmalerba
/src/material-experimental/mdc-typography/** @mmalerba
/src/material-experimental/menubar/** @jelbourn @andy9775
/src/material-experimental/menubar/** @andrewseguin @andy9775
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/src/material-experimental/menubar/** @andrewseguin @andy9775
/src/material-experimental/menubar/** @andrewseguin

/src/dev-app/button/** @jelbourn
/src/dev-app/card/** @jelbourn
/src/dev-app/button/** @andrewseguin
/src/dev-app/card/** @andrewseguin
/src/dev-app/cdk-experimental-combobox/** @jelbourn @nielsr98
/src/dev-app/cdk-experimental-listbox/** @jelbourn @nielsr98
/src/dev-app/cdk-experimental-menu/** @jelbourn @andy9775
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/src/dev-app/cdk-experimental-menu/** @jelbourn @andy9775
/src/dev-app/cdk-experimental-menu/** @jelbourn

@@ -207,47 +207,47 @@
/src/dev-app/menubar/** @jelbourn @andy9775
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/src/dev-app/menubar/** @jelbourn @andy9775
/src/dev-app/menubar/** @jelbourn

@jelbourn
Copy link
Member Author

Removed Andy and Niels

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
/src/material/core/typography/** @crisbeto
/src/material/core/util/** @jelbourn
/src/material/core/util/** @andrewseguin

# Miscellaneous components
/src/google-maps/** @mbehrlich
/src/youtube-player/** @nathantate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have more people on google-maps and youtube-player?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added you

Updating this to shuffle more code reviews from myself to @andrewseguin
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jan 7, 2022
@wagnermaciel wagnermaciel merged commit 25f4e75 into angular:master Jan 10, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 10, 2022
Updating this to shuffle more code reviews from myself to @andrewseguin

(cherry picked from commit 25f4e75)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants