build: remove unnecessary dependency on core-js
#24311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the unnecessary dependency on core-js. All browsers we support have ES2016 features built-in. ES2016 is the target the dev-app and e2e-app use for local development. We could even increase this given the Angular browser guarantees, but there is a plan needed for the zone.js async/await complications w/ Bazel. Reflect metadata will continue being used for JIT unit tests as Angular JIT relies on the TS `Reflect.metadata` emit which is non-standard.
devversion
force-pushed
the
remove-unused-deps
branch
from
3d6d769 to
4138fd8
Compare
devversion
requested review from
crisbeto
and removed request for
a team and
andrewseguin
devversion
added
merge safe
target: patch
amysorto
pushed a commit
that referenced
this pull request
Jan 31, 2022
Removes the unnecessary dependency on core-js. All browsers we support have ES2016 features built-in. ES2016 is the target the dev-app and e2e-app use for local development. We could even increase this given the Angular browser guarantees, but there is a plan needed for the zone.js async/await complications w/ Bazel. Reflect metadata will continue being used for JIT unit tests as Angular JIT relies on the TS `Reflect.metadata` emit which is non-standard. (cherry picked from commit faa3072)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the unnecessary dependency on core-js. All browsers
we support have ES2016 features built-in. ES2016 is the target
the dev-app and e2e-app use for local development. We could even
increase this given the Angular browser guarantees, but there is
a plan needed for the zone.js async/await complications w/ Bazel.