Skip to content

build: remove unnecessary dependency on core-js #24311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

build: remove unnecessary dependency on core-js #24311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"@angular/platform-browser": "13.2.0-rc.1",
"@types/google.maps": "^3.47.3",
"@types/youtube": "^0.0.46",
"core-js-bundle": "^3.20.3",
"material-components-web": "14.0.0-canary.c047f7c19.0",
"rxjs": "^6.6.7",
"rxjs-tslint-rules": "^4.34.8",
Expand Down Expand Up @@ -148,7 +147,6 @@
"@types/browser-sync": "^2.26.3",
"@types/fs-extra": "^9.0.13",
"@types/glob": "^7.2.0",
"@types/inquirer": "^7.3.1",
"@types/jasmine": "^3.10.3",
"@types/luxon": "^1.27.0",
"@types/marked": "^2.0.0",
Expand Down
1 change: 0 additions & 1 deletion src/dev-app/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ filegroup(
":theme",
":variables",
"//src/dev-app/icon:icon_demo_assets",
"@npm//:node_modules/core-js-bundle/index.js",
"@npm//:node_modules/moment/min/moment-with-locales.min.js",
"@npm//:node_modules/rxjs/bundles/rxjs.umd.min.js",
"@npm//:node_modules/zone.js/dist/zone.js",
Expand Down
1 change: 0 additions & 1 deletion src/dev-app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
<body>
<dev-app>Loading...</dev-app>

<script src="core-js-bundle/index.js"></script>
<script src="zone.js/dist/zone.js"></script>
<script src="https://www.youtube.com/iframe_api"></script>
<script src="https://unpkg.com/@googlemaps/markerclustererplus/dist/index.min.js"></script>
Expand Down
1 change: 0 additions & 1 deletion src/e2e-app/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ package(default_visibility = ["//visibility:public"])
# List of dependencies that are referenced in the `index.html` file.
devserverIndexHtmlDependencies = [
"@npm//zone.js",
"@npm//core-js-bundle",
"@npm//kagekiri",
"@npm//material-components-web",
"//src/material/prebuilt-themes:indigo-pink",
Expand Down
1 change: 0 additions & 1 deletion src/e2e-app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<e2e-app>Loading...</e2e-app>
<span class="sibling">I am a sibling!</span>

<script src="core-js-bundle/minified.js"></script>
<script src="zone.js/dist/zone.min.js"></script>
<script src="kagekiri/dist/kagekiri.umd.min.js"></script>
<script src="bundles/e2e-app/main.js" type="module"></script>
Expand Down
3 changes: 1 addition & 2 deletions test/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ module.exports = config => {
},
],
files: [
{pattern: 'node_modules/core-js-bundle/minified.js', included: true, watched: false},
{pattern: 'node_modules/core-js-bundle/minified.js.map', included: false, watched: false},
{pattern: 'node_modules/reflect-metadata/Reflect.js', included: true, watched: false},
{pattern: 'node_modules/zone.js/dist/zone.min.js', included: true, watched: false},
{pattern: 'node_modules/zone.js/dist/proxy.min.js', included: true, watched: false},
{pattern: 'node_modules/zone.js/dist/sync-test.js', included: true, watched: false},
Expand Down
20 changes: 0 additions & 20 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3098,14 +3098,6 @@
dependencies:
"@types/node" "*"

"@types/inquirer@^7.3.1":
version "7.3.3"
resolved "https://registry.yarnpkg.com/@types/inquirer/-/inquirer-7.3.3.tgz#92e6676efb67fa6925c69a2ee638f67a822952ac"
integrity sha512-HhxyLejTHMfohAuhRun4csWigAMjXTmRyiJTU1Y/I1xmggikFMkOUoMQRlFm+zQcPEGHSs3io/0FAmNZf8EymQ==
dependencies:
"@types/through" "*"
rxjs "^6.4.0"

"@types/is-windows@^1.0.0":
version "1.0.0"
resolved "https://registry.yarnpkg.com/@types/is-windows/-/is-windows-1.0.0.tgz#1011fa129d87091e2f6faf9042d6704cdf2e7be0"
Expand Down Expand Up @@ -3333,13 +3325,6 @@
dependencies:
"@types/node" "*"

"@types/through@*":
version "0.0.30"
resolved "https://registry.yarnpkg.com/@types/through/-/through-0.0.30.tgz#e0e42ce77e897bd6aead6f6ea62aeb135b8a3895"
integrity sha512-FvnCJljyxhPM3gkRgWmxmDZyAQSiBQQWLI0A0VFL0K7W1oRUrPJSqNO0NvTnLkBcotdlp3lKvaT0JrnyRDkzOg==
dependencies:
"@types/node" "*"

"@types/tmp@^0.2.1":
version "0.2.3"
resolved "https://registry.yarnpkg.com/@types/tmp/-/tmp-0.2.3.tgz#908bfb113419fd6a42273674c00994d40902c165"
Expand Down Expand Up @@ -5520,11 +5505,6 @@ [email protected]:
schema-utils "^4.0.0"
serialize-javascript "^6.0.0"

core-js-bundle@^3.20.3:
version "3.20.3"
resolved "https://registry.yarnpkg.com/core-js-bundle/-/core-js-bundle-3.20.3.tgz#d9311c2e2860cd4ab6f013009c700be89cdc19d9"
integrity sha512-IbYKbDcQhw0Cwsd0J5LKaK4juegyQuoAXCzW5iOeJKMf5pQOL5kknkJKJdS1nhtThCdT9/QWUGYgfFDOIpxaLA==

core-js-compat@^3.20.0, core-js-compat@^3.20.2:
version "3.20.3"
resolved "https://registry.yarnpkg.com/core-js-compat/-/core-js-compat-3.20.3.tgz#d71f85f94eb5e4bea3407412e549daa083d23bd6"
Expand Down