Skip to content

fix(material/list): add selected shape to list item #25901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(material/list): add selected shape to list item #25901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/material/list/list-option.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,11 @@
// Improve accessibility for Window High Contrast Mode (HCM) by adding an idicator on the selected
// option.
@include list-item-hcm-indicator.private-high-contrast-list-item-indicator();

// Add a 4px border radius so that selected state is communicated with both color and shape. Fix
// accessibility issue where selected state is visually communicated only with color (issue
// #25900, WCAG 1.4.1).
&::before {
border-radius: 4px; // 4dp is a common Material Design value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how much this helps with the selected indication. I had to zoom in on my screen to notice the difference.

}
}