Skip to content

fix(material/list): add selected shape to list item #25901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Oct 31, 2022

Add a 4px border radius to selected-state of list item. Fix issue where selected state is visually communicated only with color (#25900, WCAG 1.4.1).

Fix #25900

Add a 4px border radius to selected-state of list item. Fix issue where
selected state is visually communicated only with color (angular#25900, WCAG
1.4.1).

Fix angular#25900
@zarend zarend added Accessibility This issue is related to accessibility (a11y) area: material/list target: rc This PR is targeted for the next release-candidate labels Oct 31, 2022
// accessibility issue where selected state is visually communicated only with color (issue
// #25900, WCAG 1.4.1).
&::before {
border-radius: 4px; // 4dp is a common Material Design value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how much this helps with the selected indication. I had to zoom in on my screen to notice the difference.

@zarend zarend marked this pull request as draft November 1, 2022 14:28
@zarend
Copy link
Contributor Author

zarend commented Nov 7, 2022

Closing in favor of #25933

@zarend zarend closed this Nov 7, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) area: material/list target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(material/list): selected state is visually communicated only with color (WCAG 1.4.1)
2 participants