fix(material/list): add radio toggles #25933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
zarend
requested review from
andrewseguin,
crisbeto,
devversion and
mmalerba
as code owners
zarend
force-pushed
the
mdc-list-radio
branch
2 times, most recently
from
2683a4f to
18ea893
Compare
crisbeto
reviewed
Nov 8, 2022
zarend
force-pushed
the
mdc-list-radio
branch
6 times, most recently
from
8e892c4 to
8072226
Compare
|
Hi all, I've made fixes to respond to PR comments
@crisbeto does this PR look good to you? |
crisbeto
reviewed
Nov 9, 2022
zarend
force-pushed
the
mdc-list-radio
branch
from
8072226 to
643361b
Compare
zarend
added
target: minor
zarend
force-pushed
the
mdc-list-radio
branch
from
643361b to
884e6b5
Compare
|
I've made fixed based on PR comments and changed the target to minor:
|
mmalerba
approved these changes
Nov 9, 2022
Add radio toggles for single selection. Fix a11y issue where selected state is visually communicated with color alone. Rename `checkboxPosition` Input to `togglePosition` and deprecate `checkboxPosition`. `togglePosition` configures the position of both the radio and checkbox indicators. `checkboxPosition` also configures the position of both. Summary of API and behavior changes: - MDC List displays radio indicators for single-selection - rename `checkboxPosition` Input to `togglePosition` - rename `type MatListOptionCheckboxPosition` to `type MatListOptionTogglePosition` DEPRECTED: * `checkboxPosition` is deprecated because `togglePosition` replaces it * `MatListOptionCheckboxPosition` is deprecated because `MatListOptionTogglePosition` replaces it Closes angular#7157, Fixes angular#25900
zarend
force-pushed
the
mdc-list-radio
branch
from
884e6b5 to
eccc4a8
Compare
|
changes since this was last reviewed:
|
zarend
added a commit
to zarend/components
that referenced
this pull request
Dec 16, 2022
Add an opt-out for radio indicators for single-selection. Adds both an Input and DI token to specify if radio indicators are hidden. By default, display radio indicators. If both DI token and Input are specified, the Input wins. PR angular#25933 added radio toggles for single-selection. Add an opt-out to provide a way to have same appearance as before angular#25933. API changes - add `@Input hideSingleSelectionIndicator` to specify if radio indicators are displayed - add MAT_LIST_CONFIG token to specify default value for `hideSingleSelectionIndicator`
zarend
added a commit
to zarend/components
that referenced
this pull request
Dec 16, 2022
Add an opt-out for radio indicators for single-selection. Adds both an Input and DI token to specify if radio indicators are hidden. By default, display radio indicators. If both DI token and Input are specified, the Input wins. PR angular#25933 added radio toggles for single-selection. Add an opt-out to provide a way to have same appearance as before angular#25933. API changes - add `@Input hideSingleSelectionIndicator` to specify if radio indicators are displayed - add MAT_LIST_CONFIG token to specify default value for `hideSingleSelectionIndicator`
zarend
added a commit
that referenced
this pull request
Dec 20, 2022
Add an opt-out for radio indicators for single-selection. Adds both an Input and DI token to specify if radio indicators are hidden. By default, display radio indicators. If both DI token and Input are specified, the Input wins. PR #25933 added radio toggles for single-selection. Add an opt-out to provide a way to have same appearance as before #25933. API changes - add `@Input hideSingleSelectionIndicator` to specify if radio indicators are displayed - add MAT_LIST_CONFIG token to specify default value for `hideSingleSelectionIndicator`
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(material/list): add radio toggles
Add radio toggles for single selection. Fix a11y issue where selected
state is visually communicated with color alone.
Rename
checkboxPositionInput totogglePositionand deprecatecheckboxPosition.togglePositionconfigures the position of both theradio and checkbox indicators.
checkboxPositionalso configures theposition of both.
Summary of API and behavior changes:
checkboxPositionInput totogglePositiontype MatListOptionCheckboxPositiontotype MatListOptionTogglePositionDEPRECTED:
checkboxPositionis deprecated becausetogglePositionreplaces itMatListOptionCheckboxPositionis deprecated becauseMatListOptionTogglePositionreplaces itCloses #7157, Fixes #25900