-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update to Angular 15 final #26031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0216a3
to
b68e9f9
Compare
34d5ab5
to
7090e99
Compare
@@ -10,24 +10,24 @@ | |||
}, | |||
"private": true, | |||
"dependencies": { | |||
"@angular/animations": "file:../../node_modules/@angular/animations", | |||
"@angular/animations": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devversion I had to change these dependencies, because they were causing a mismatch which was breaking the build. I saw that we already had something similar in the Yarn PnP test as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. Out of curiosity: If the root package.json would be using 15.0.0
too, why would it be different this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, my guess is that a transitive dependency somewhere was causing it. I actually only needed to set a specific version for @angular-devkit/build-angular
to fix the problem, but it would've looked weird if this was the only package with a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I can tell you that dependencies like @angular/animations
will regardless end up using the workspace @angular/animations
package (due to the integration Bazel rule), but yes- there might be something with transitive dependencies.
Also build-angular
will end up being the one from the project package.json
: https://github.com/angular/components/blob/main/tools/integration.bzl#L12.
Bumps the various dependencies to Angular 15 final.
7090e99
to
7a0f551
Compare
Bumps the various dependencies to Angular 15 final. (cherry picked from commit d3a14f6)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bumps the various dependencies to Angular 15 final.