Skip to content

build: update to Angular 15 final #26031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Conversation

crisbeto
Copy link
Member

Bumps the various dependencies to Angular 15 final.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Nov 19, 2022
@crisbeto crisbeto force-pushed the ng-15-final branch 3 times, most recently from 34d5ab5 to 7090e99 Compare November 19, 2022 14:46
@@ -10,24 +10,24 @@
},
"private": true,
"dependencies": {
"@angular/animations": "file:../../node_modules/@angular/animations",
"@angular/animations": "^15.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devversion I had to change these dependencies, because they were causing a mismatch which was breaking the build. I saw that we already had something similar in the Yarn PnP test as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Out of curiosity: If the root package.json would be using 15.0.0 too, why would it be different this way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, my guess is that a transitive dependency somewhere was causing it. I actually only needed to set a specific version for @angular-devkit/build-angular to fix the problem, but it would've looked weird if this was the only package with a version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I can tell you that dependencies like @angular/animations will regardless end up using the workspace @angular/animations package (due to the integration Bazel rule), but yes- there might be something with transitive dependencies.

Also build-angular will end up being the one from the project package.json: https://github.com/angular/components/blob/main/tools/integration.bzl#L12.

Bumps the various dependencies to Angular 15 final.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 19, 2022
@crisbeto crisbeto merged commit d3a14f6 into angular:main Nov 19, 2022
crisbeto added a commit that referenced this pull request Nov 19, 2022
Bumps the various dependencies to Angular 15 final.

(cherry picked from commit d3a14f6)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants