Skip to content

build: update to Angular 15 final #26031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2022
Merged

build: update to Angular 15 final #26031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5,347 changes: 2,061 additions & 3,286 deletions integration/harness-e2e-cli/yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions integration/ng-add-standalone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,24 @@
},
"private": true,
"dependencies": {
"@angular/animations": "file:../../node_modules/@angular/animations",
"@angular/animations": "^15.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devversion I had to change these dependencies, because they were causing a mismatch which was breaking the build. I saw that we already had something similar in the Yarn PnP test as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Out of curiosity: If the root package.json would be using 15.0.0 too, why would it be different this way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, my guess is that a transitive dependency somewhere was causing it. I actually only needed to set a specific version for @angular-devkit/build-angular to fix the problem, but it would've looked weird if this was the only package with a version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I can tell you that dependencies like @angular/animations will regardless end up using the workspace @angular/animations package (due to the integration Bazel rule), but yes- there might be something with transitive dependencies.

Also build-angular will end up being the one from the project package.json: https://github.com/angular/components/blob/main/tools/integration.bzl#L12.

"@angular/cdk": "file:../../dist/releases/cdk",
"@angular/common": "file:../../node_modules/@angular/common",
"@angular/compiler": "file:../../node_modules/@angular/compiler",
"@angular/core": "file:../../node_modules/@angular/core",
"@angular/forms": "file:../../node_modules/@angular/forms",
"@angular/common": "^15.0.0",
"@angular/compiler": "^15.0.0",
"@angular/core": "^15.0.0",
"@angular/forms": "^15.0.0",
"@angular/material": "file:../../dist/releases/material",
"@angular/platform-browser": "file:../../node_modules/@angular/platform-browser",
"@angular/platform-browser-dynamic": "file:../../node_modules/@angular/platform-browser-dynamic",
"@angular/router": "file:../../node_modules/@angular/router",
"rxjs": "file:../../node_modules/rxjs",
"@angular/platform-browser": "^15.0.0",
"@angular/platform-browser-dynamic": "^15.0.0",
"@angular/router": "^15.0.0",
"rxjs": "~7.5.0",
"tslib": "^2.3.0",
"zone.js": "~0.11.4"
},
"devDependencies": {
"@angular-devkit/build-angular": "file:../../node_modules/@angular-devkit/build-angular",
"@angular/cli": "file:../../node_modules/@angular/cli",
"@angular/compiler-cli": "file:../../node_modules/@angular/compiler-cli",
"@angular-devkit/build-angular": "^15.0.0",
"@angular/cli": "^15.0.0",
"@angular/compiler-cli": "^15.0.0",
"@types/jasmine": "~3.9.0",
"@types/node": "^12.11.1",
"glob": "^7.2.0",
Expand Down
Loading