Skip to content

build: update to TypeScript 4.9 #26380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023
Merged

build: update to TypeScript 4.9 #26380

merged 1 commit into from
Jan 7, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 7, 2023

Updates most packages to the latest RC and to TypeScript 4.9.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate labels Jan 7, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 7, 2023
"@angular-devkit/build-angular": "^15.1.0-rc.0",
"@angular-devkit/core": "^15.1.0-rc.0",
"@angular-devkit/schematics": "^15.1.0-rc.0",
"@angular/bazel": "15.1.0-next.3",
Copy link
Member Author

@crisbeto crisbeto Jan 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried updating @angular/bazel as well, but I couldn't get the build to work, likely because of the changes mentioned in #26357. One of the errors was because we don't need the devmode-es2020-bazel.patch, but after removing it, I had some very vague errors from Bazel like:

ERROR: material2/src/material/progress-bar/testing/BUILD.bazel:5:10: for src/material/progress-bar/testing/index.d.ts, previous action: action 'Compiling Angular templates (full prodmode) //src/material/progress-bar/testing:testing', attempted action: action 'Compiling Angular templates (full devmode) //src/material/progress-bar/testing:testing'
ERROR: Analysis of target '//src/material/progress-bar/testing:testing' failed; build aborted: 
INFO: Elapsed time: 51.064s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (284 packages loaded, 13767 targets configured)
error Command failed with exit code 1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it needs much more changes in this repo to be able to update. It should be fine not updating, or do you need it for TS?

Copy link
Member Author

@crisbeto crisbeto Jan 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't need it for the TS update, I tried updating it for consistency.

Updates most packages to the latest RC and to TypeScript 4.9.
@crisbeto crisbeto marked this pull request as ready for review January 7, 2023 09:21
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 7, 2023
@crisbeto crisbeto merged commit e337fe8 into angular:main Jan 7, 2023
crisbeto added a commit that referenced this pull request Jan 7, 2023
Updates most packages to the latest RC and to TypeScript 4.9.

(cherry picked from commit e337fe8)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants