Skip to content

build: update to TypeScript 4.9 #26380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023
Merged

build: update to TypeScript 4.9 #26380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
783 changes: 0 additions & 783 deletions integration/yarn-pnp-compat/.yarn/releases/yarn-3.2.3.cjs
View file
Open in desktop

This file was deleted.

823 changes: 823 additions & 0 deletions integration/yarn-pnp-compat/.yarn/releases/yarn-3.3.1.cjs
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration/yarn-pnp-compat/.yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
nodeLinker: pnp

yarnPath: .yarn/releases/yarn-3.2.3.cjs
yarnPath: .yarn/releases/yarn-3.3.1.cjs
2 changes: 1 addition & 1 deletion integration/yarn-pnp-compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@
"karma-jasmine-html-reporter": "~1.7.0",
"typescript": "file:../../node_modules/typescript"
},
"packageManager": "yarn@3.2.3"
"packageManager": "yarn@3.3.1"
}
42 changes: 21 additions & 21 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@
},
"version": "15.2.0-next.0",
"dependencies": {
"@angular/animations": "^15.1.0-next.3",
"@angular/common": "^15.1.0-next.3",
"@angular/compiler": "^15.1.0-next.3",
"@angular/core": "^15.1.0-next.3",
"@angular/forms": "^15.1.0-next.3",
"@angular/platform-browser": "^15.1.0-next.3",
"@angular/animations": "^15.1.0-rc.0",
"@angular/common": "^15.1.0-rc.0",
"@angular/compiler": "^15.1.0-rc.0",
"@angular/core": "^15.1.0-rc.0",
"@angular/forms": "^15.1.0-rc.0",
"@angular/platform-browser": "^15.1.0-rc.0",
"@types/google.maps": "^3.47.3",
"@types/youtube": "^0.0.46",
"rxjs": "^6.6.7",
Expand All @@ -69,18 +69,18 @@
"zone.js": "~0.11.5"
},
"devDependencies": {
"@angular-devkit/build-angular": "^15.1.0-next.3",
"@angular-devkit/core": "^15.1.0-next.3",
"@angular-devkit/schematics": "^15.1.0-next.3",
"@angular/bazel": "^15.1.0-next.3",
"@angular-devkit/build-angular": "^15.1.0-rc.0",
"@angular-devkit/core": "^15.1.0-rc.0",
"@angular-devkit/schematics": "^15.1.0-rc.0",
"@angular/bazel": "15.1.0-next.3",
Copy link
Member Author

@crisbeto crisbeto Jan 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried updating @angular/bazel as well, but I couldn't get the build to work, likely because of the changes mentioned in #26357. One of the errors was because we don't need the devmode-es2020-bazel.patch, but after removing it, I had some very vague errors from Bazel like:

ERROR: material2/src/material/progress-bar/testing/BUILD.bazel:5:10: for src/material/progress-bar/testing/index.d.ts, previous action: action 'Compiling Angular templates (full prodmode) //src/material/progress-bar/testing:testing', attempted action: action 'Compiling Angular templates (full devmode) //src/material/progress-bar/testing:testing'
ERROR: Analysis of target '//src/material/progress-bar/testing:testing' failed; build aborted: 
INFO: Elapsed time: 51.064s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (284 packages loaded, 13767 targets configured)
error Command failed with exit code 1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it needs much more changes in this repo to be able to update. It should be fine not updating, or do you need it for TS?

Copy link
Member Author

@crisbeto crisbeto Jan 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't need it for the TS update, I tried updating it for consistency.

"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#1fd144d9f9db6a6cfe3e2617c4fc70e119a400cb",
"@angular/cli": "^15.1.0-next.3",
"@angular/compiler-cli": "^15.1.0-next.3",
"@angular/localize": "^15.1.0-next.3",
"@angular/cli": "^15.1.0-rc.0",
"@angular/compiler-cli": "^15.1.0-rc.0",
"@angular/localize": "^15.1.0-rc.0",
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#20d1bd232100d278c53820226427039f51881d3f",
"@angular/platform-browser-dynamic": "^15.1.0-next.3",
"@angular/platform-server": "^15.1.0-next.3",
"@angular/router": "^15.1.0-next.3",
"@angular/platform-browser-dynamic": "^15.1.0-rc.0",
"@angular/platform-server": "^15.1.0-rc.0",
"@angular/router": "^15.1.0-rc.0",
"@axe-core/webdriverjs": "^4.3.2",
"@babel/core": "^7.16.12",
"@bazel/bazelisk": "1.12.1",
Expand Down Expand Up @@ -145,7 +145,7 @@
"@octokit/rest": "18.3.5",
"@rollup/plugin-commonjs": "^21.0.0",
"@rollup/plugin-node-resolve": "^13.1.3",
"@schematics/angular": "^15.1.0-next.3",
"@schematics/angular": "^15.1.0-rc.0",
"@types/babel__core": "^7.1.18",
"@types/browser-sync": "^2.26.3",
"@types/fs-extra": "^9.0.13",
Expand Down Expand Up @@ -215,17 +215,17 @@
"tsickle": "0.39.1",
"tslint": "^6.1.3",
"tsutils": "^3.21.0",
"typescript": "~4.8.2",
"typescript": "~4.9.3",
"vrsource-tslint-rules": "6.0.0",
"yaml": "^1.10.2",
"yargs": "^17.3.1",
"zx": "^6.2.4"
},
"resolutions": {
"@angular/build-tooling/typescript": "~4.8.2",
"@angular/ng-dev/typescript": "~4.8.2",
"@angular/build-tooling/typescript": "~4.9.3",
"@angular/ng-dev/typescript": "~4.9.3",
"browser-sync-client": "2.26.13",
"dgeni-packages/typescript": "~4.8.2",
"dgeni-packages/typescript": "~4.9.3",
"**/https-proxy-agent": "5.0.0"
}
}
2 changes: 1 addition & 1 deletion scripts/caretaking/firebase-functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"firebase-functions": "^3.11.0"
},
"devDependencies": {
"typescript": "~4.8.2",
"typescript": "~4.9.3",
"firebase-tools": "^8.6.0"
},
"private": true
Expand Down
Loading