build: add most components to kitchen-sink #4836
Conversation
googlebot
added
the
cla: yes
| @@ -48,6 +48,10 @@ export class InteractivityChecker { | |||
| * @returns Whether the element is tabbable. | |||
| */ | |||
| isTabbable(element: HTMLElement): boolean { | |||
| // Nothing is tabbable on the the server 😎 | |||
There was a problem hiding this comment.
We need a lint rule for that! 😄 (joke)
src/lib/slide-toggle/slide-toggle.ts
Outdated
| this._thumbBarEl = _elementRef.nativeElement.querySelector('.mat-slide-toggle-bar'); | ||
| constructor(private _elementRef: ElementRef, platform: Platform) { | ||
| // We only need to interact with these elements when we're on the browser, so only grab | ||
| // the refernece in that case. |
There was a problem hiding this comment.
Typo for reference.
Also we are already in the custom renderer? I suppose the whole custom renderer approach will be addressed in the future at some point.
Just thought that we could not create the Renderer if we are not in the browser
There was a problem hiding this comment.
That's the long-term plan, but that will require the secondary @angular/material/server package
|
Still trying to fix these test failures, which happen inconsistently locally |
jelbourn
force-pushed
the
kitchen-sink
branch
2 times, most recently
from
31b519e to
e641d43
Compare
|
All failures resolved (the red status is coming from the "Deploy" tasks not running, which is something wrong with our Travis config for PRs at the moment) |
jelbourn
force-pushed
the
kitchen-sink
branch
3 times, most recently
from
9edcd1d to
5ef2422
Compare
* build: add most components to kitchen-sink * debug Terrible code just exporting for the sake of asking an question to Andrew
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a handful of issues that prevent some components from working.
Checkbox and button-toggles don't work due to an issue in platform-server.
Tabs don't work because they try to set a
styleproperty directly on initialization; this will need a more in-depth follow-up (I didn't look into that deeply).Related to #308