-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(chips): Add chip avatar and chip trailing icon #9557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/lib/chips/chips.scss
Outdated
|
||
.mat-chip:not(.mat-basic-chip) { | ||
.mat-chip.mat-standard-chip { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need the extra specificity from .mat-chip
, or can you just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
src/lib/chips/chips.scss
Outdated
|
||
[dir='rtl'] & { | ||
margin: 0; | ||
margin-bottom: $mat-chips-chip-margin; | ||
padding-left: $mat-chip-remove-after-padding; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you also need to zero out the padding-right
?
src/lib/chips/chips.scss
Outdated
&:last-child, [dir='rtl'] &:last-child { | ||
margin-bottom: 0; | ||
[dir='rtl'] & { | ||
padding-right: $mat-chip-avatar-before-padding; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zero out padding-left
?
src/lib/chips/chips.scss
Outdated
margin-right: $mat-chip-avatar-after-margin; | ||
|
||
[dir='rtl'] & { | ||
margin-left: $mat-chip-avatar-after-margin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zero out margin-right
src/lib/chips/chips.scss
Outdated
margin-left: $mat-chip-remove-before-margin; | ||
|
||
[dir='rtl'] & { | ||
margin-right: $mat-chip-remove-before-margin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zero out margin-left
src/demo-app/chips/chips-demo.html
Outdated
<mat-chip> | ||
<mat-icon matChipAvatar>home</mat-icon> | ||
Home | ||
<mat-icon matChipRemove matChipTrailingIcon>cancel</mat-icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does matChipTrailingIcon
do? it looks the same as the example above where you only applied matChipRemove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan is that matChipRemove
is responsible for the remove action, and matChipTrailingIcon
is responsible for the styling. The trailing icon can be a status icon instead of X.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, do these examples need both directives? It seems like just matChipRemove would be sufficient since does everything that trailing icon does + some extra behavior. In fact you could probably make the CSS simpler by having matChipRemove
just apply the mat-chip-trailing-icon
class .
Also should add an example of a trailing icon that isn't a remove icon
@@ -31,6 +31,47 @@ <h4>Advanced</h4> | |||
</mat-chip> | |||
</mat-chip-list> | |||
<div>{{message}}</div> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add color example with avatar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review.
Made some changes: Removed MatBasicChip and MatStandardChip, use the same way as button variant to add css class.
src/demo-app/chips/chips-demo.html
Outdated
<mat-chip> | ||
<mat-icon matChipAvatar>home</mat-icon> | ||
Home | ||
<mat-icon matChipRemove matChipTrailingIcon>cancel</mat-icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan is that matChipRemove
is responsible for the remove action, and matChipTrailingIcon
is responsible for the styling. The trailing icon can be a status icon instead of X.
src/lib/chips/chips.scss
Outdated
|
||
.mat-chip:not(.mat-basic-chip) { | ||
.mat-chip.mat-standard-chip { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from any comments from @mmalerba
Added examples in demo, and added |
LGTM |
* feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo
* feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo
* feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo
* feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo
…ter (#9762) * feat(form-field): support for different spec variants (#9366) * feat(form-field): implement hover state [Based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states) form fields should have a hover state where the underline gets darkened while the user is hovering and gets replaced by the theme color after the focus the input. * branch css logic * extract underline css into standard variant * box variant underline * box variant spacing * add legacy variant * fix select ellipsis * move hover state changes out of legacy variant * add variants section to input demo * use filter/backface-visibility to address label jumpiness * address comments * fix box variant text fuzziness * remove bluriness fixes that aren't needed anymore * address comments * remove the floatLabel=never option in the new variants * variant --> appearance * add tests for new label & placeholder behavior * update demo to use mat-label * fix bazel build * feat(chips): Add chip avatar and chip trailing icon (#9557) * feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo * fix(form-field): rename box to fill and tweak the styles a bit (#9636) * make some tweaks to the box appearance * rename 'box' appearance to 'fill' * feat(form-field): add outline style (#9705) * remove datepicker reliance on form-field's underlineRef * add spacing and alignment rules for outline variant * outline color & thickness * style tweaks * correctly position and size the gap * address comments * fix(form-field): correct prefix & suffix icons as well as select arrow for various form field appearances (#9743) * feat(input): add utilities for custom styling and monitoring state of input autofill (#9719) * add utility for monitoring input autofill * add scss mixin for styling input autofill colors * tests * move everything from cdk to MatInputModule * address comments * add doc comments * fix(form-field): fixes for outline appearance (#9759) * use the `AutofillMonitor` in `MatInput` * Make `updateOutlineGap` public so users can call it if needed * feat(chips): add ripple to chips (#9761) * fix(form-field, chips): fix tests & lint (#9767) * undo change that caused darkened color for legacy form field * fix change detection * fix(chips): remove margin for chip list (#9793) * add terminateOnPointerUp to ripple config
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
demo: https://tina-demo1.firebaseapp.com/chips