feat(chips): Add chip avatar and chip trailing icon #9557

tinayuangao · 2018-01-24T01:31:25Z

demo: https://tina-demo1.firebaseapp.com/chips

mmalerba · 2018-01-24T17:55:48Z

src/lib/chips/chips.scss


-.mat-chip:not(.mat-basic-chip) {
+.mat-chip.mat-standard-chip {


does this need the extra specificity from .mat-chip, or can you just remove it?

mmalerba · 2018-01-24T18:01:02Z

src/lib/chips/chips.scss


    [dir='rtl'] & {
-      margin: 0;
-      margin-bottom: $mat-chips-chip-margin;
+      padding-left: $mat-chip-remove-after-padding;


do you also need to zero out the padding-right?

mmalerba · 2018-01-24T18:01:21Z

src/lib/chips/chips.scss

-    &:last-child, [dir='rtl'] &:last-child {
-      margin-bottom: 0;
+    [dir='rtl'] & {
+      padding-right: $mat-chip-avatar-before-padding;


zero out padding-left?

mmalerba · 2018-01-24T18:04:22Z

src/lib/chips/chips.scss

+    margin-right: $mat-chip-avatar-after-margin;
+
+    [dir='rtl'] & {
+      margin-left: $mat-chip-avatar-after-margin;


zero out margin-right

mmalerba · 2018-01-24T18:04:45Z

src/lib/chips/chips.scss

+    margin-left: $mat-chip-remove-before-margin;
+
+    [dir='rtl'] & {
+      margin-right: $mat-chip-remove-before-margin;


zero out margin-left

mmalerba · 2018-01-24T18:12:29Z

src/demo-app/chips/chips-demo.html

+        <mat-chip>
+          <mat-icon matChipAvatar>home</mat-icon>
+          Home
+          <mat-icon matChipRemove matChipTrailingIcon>cancel</mat-icon>


what does matChipTrailingIcon do? it looks the same as the example above where you only applied matChipRemove

My plan is that matChipRemove is responsible for the remove action, and matChipTrailingIcon is responsible for the styling. The trailing icon can be a status icon instead of X.

Ah ok, do these examples need both directives? It seems like just matChipRemove would be sufficient since does everything that trailing icon does + some extra behavior. In fact you could probably make the CSS simpler by having matChipRemove just apply the mat-chip-trailing-icon class .

Also should add an example of a trailing icon that isn't a remove icon

mmalerba · 2018-01-24T18:14:33Z

src/demo-app/chips/chips-demo.html

@@ -31,6 +31,47 @@ <h4>Advanced</h4>
        </mat-chip>
      </mat-chip-list>
      <div>{{message}}</div>
+


add color example with avatar

tinayuangao

Thanks for review.

Made some changes: Removed MatBasicChip and MatStandardChip, use the same way as button variant to add css class.

tinayuangao · 2018-01-24T18:57:47Z

src/demo-app/chips/chips-demo.html

+        <mat-chip>
+          <mat-icon matChipAvatar>home</mat-icon>
+          Home
+          <mat-icon matChipRemove matChipTrailingIcon>cancel</mat-icon>


My plan is that matChipRemove is responsible for the remove action, and matChipTrailingIcon is responsible for the styling. The trailing icon can be a status icon instead of X.

tinayuangao · 2018-01-24T18:58:00Z

src/lib/chips/chips.scss


-.mat-chip:not(.mat-basic-chip) {
+.mat-chip.mat-standard-chip {


jelbourn

LGTM aside from any comments from @mmalerba

demo

tinayuangao · 2018-01-24T22:58:12Z

Added examples in demo, and added mat-chip-trailing-icon to MatChipRemove. Thanks!

mmalerba · 2018-01-25T02:13:35Z

LGTM

* feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo

…ter (#9762) * feat(form-field): support for different spec variants (#9366) * feat(form-field): implement hover state [Based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states) form fields should have a hover state where the underline gets darkened while the user is hovering and gets replaced by the theme color after the focus the input. * branch css logic * extract underline css into standard variant * box variant underline * box variant spacing * add legacy variant * fix select ellipsis * move hover state changes out of legacy variant * add variants section to input demo * use filter/backface-visibility to address label jumpiness * address comments * fix box variant text fuzziness * remove bluriness fixes that aren't needed anymore * address comments * remove the floatLabel=never option in the new variants * variant --> appearance * add tests for new label & placeholder behavior * update demo to use mat-label * fix bazel build * feat(chips): Add chip avatar and chip trailing icon (#9557) * feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo * fix(form-field): rename box to fill and tweak the styles a bit (#9636) * make some tweaks to the box appearance * rename 'box' appearance to 'fill' * feat(form-field): add outline style (#9705) * remove datepicker reliance on form-field's underlineRef * add spacing and alignment rules for outline variant * outline color & thickness * style tweaks * correctly position and size the gap * address comments * fix(form-field): correct prefix & suffix icons as well as select arrow for various form field appearances (#9743) * feat(input): add utilities for custom styling and monitoring state of input autofill (#9719) * add utility for monitoring input autofill * add scss mixin for styling input autofill colors * tests * move everything from cdk to MatInputModule * address comments * add doc comments * fix(form-field): fixes for outline appearance (#9759) * use the `AutofillMonitor` in `MatInput` * Make `updateOutlineGap` public so users can call it if needed * feat(chips): add ripple to chips (#9761) * fix(form-field, chips): fix tests & lint (#9767) * undo change that caused darkened color for legacy form field * fix change detection * fix(chips): remove margin for chip list (#9793) * add terminateOnPointerUp to ripple config

angular-automatic-lock-bot · 2019-09-08T05:02:41Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

feat(chips): Add chip avatar and chip trailing icon

1433949

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2018

tinayuangao requested review from mmalerba and jelbourn January 24, 2018 01:31

tinayuangao added the pr: needs review label Jan 24, 2018

mmalerba reviewed Jan 24, 2018

View reviewed changes

Removed MatBasicChip and MatStandardChip

9718766

tinayuangao commented Jan 24, 2018

View reviewed changes

jelbourn approved these changes Jan 24, 2018

View reviewed changes

Add mat-chip-trailing-icon style to MatChipRemove and add examples in

b8a8205

demo

mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 25, 2018

tinayuangao merged commit ef86655 into angular:input-chip Jan 26, 2018

jelbourn added the target: minor This PR is targeted for the next minor release label Jan 29, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019


		.mat-chip:not(.mat-basic-chip) {
		.mat-chip.mat-standard-chip {

feat(chips): Add chip avatar and chip trailing icon #9557

feat(chips): Add chip avatar and chip trailing icon #9557

Uh oh!

Conversation

tinayuangao commented Jan 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tinayuangao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tinayuangao commented Jan 24, 2018

Uh oh!

mmalerba commented Jan 25, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Uh oh!

jelbourn left a comment •

edited

Loading