feat(form-field): add outline style #9705

mmalerba · 2018-01-30T23:13:23Z

Demo: https://mmalerba-demo2.firebaseapp.com/input

Known issues:

Gap size is not recalculated if label size changes after initialization.
Gap doesn't open if label floats due to browser autofill (will address in later PR)
Doesn't handle right-aligned labels properly

jelbourn · 2018-01-30T23:42:50Z

src/lib/autocomplete/autocomplete-trigger.ts

@@ -517,7 +517,7 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, OnDestroy {
  }

  private _getConnectedElement(): ElementRef {
-    return this._formField ? this._formField._connectionContainerRef : this._element;
+    return this._formField ? this._formField.getPopupConnectionElementRef() : this._element;


How about getConnectedOverlayOrigin? I want to save the term "popup" in case we ever make one as its own thing (a la xap-bubble). We also use the term "origin" throughout the overlay positioning code to refer to this element.

ghost · 2018-01-31T08:07:44Z

I have two comments:

Are you sure that ALL types of text fields should can get this styling? When I look at the guidelines it looks like only the text area type should can get this styling:

Text areas should have a visible border, using the same color and thickness as the input line.

In your demo the label floats on the outline if it's active or contains content, but according to the guidelines it should stay within the border:

Source: https://material.io/guidelines/components/text-fields.html#text-fields-field-types

willshowell · 2018-01-31T13:34:35Z

This is really exciting! 😄 I did notice one issue with the gap (shown in ltr and rtl)

mmalerba · 2018-01-31T19:39:21Z

@willshowell Updated the known issues list to mention that right-aligned labels don't work. We might have to go back to having an alignment @Input() on the mat-form-field, something we had in the past but got rid of because it seemed redundant.

mmalerba · 2018-01-31T19:48:47Z

@jelbourn comments addressed

jelbourn

LGTM

* remove datepicker reliance on form-field's underlineRef * add spacing and alignment rules for outline variant * outline color & thickness * style tweaks * correctly position and size the gap * address comments

smile2014 · 2018-02-02T07:18:21Z

The input box is too high, too space

* remove datepicker reliance on form-field's underlineRef * add spacing and alignment rules for outline variant * outline color & thickness * style tweaks * correctly position and size the gap * address comments

…ter (#9762) * feat(form-field): support for different spec variants (#9366) * feat(form-field): implement hover state [Based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states) form fields should have a hover state where the underline gets darkened while the user is hovering and gets replaced by the theme color after the focus the input. * branch css logic * extract underline css into standard variant * box variant underline * box variant spacing * add legacy variant * fix select ellipsis * move hover state changes out of legacy variant * add variants section to input demo * use filter/backface-visibility to address label jumpiness * address comments * fix box variant text fuzziness * remove bluriness fixes that aren't needed anymore * address comments * remove the floatLabel=never option in the new variants * variant --> appearance * add tests for new label & placeholder behavior * update demo to use mat-label * fix bazel build * feat(chips): Add chip avatar and chip trailing icon (#9557) * feat(chips): Add chip avatar and chip trailing icon * Removed MatBasicChip and MatStandardChip * Add mat-chip-trailing-icon style to MatChipRemove and add examples in demo * fix(form-field): rename box to fill and tweak the styles a bit (#9636) * make some tweaks to the box appearance * rename 'box' appearance to 'fill' * feat(form-field): add outline style (#9705) * remove datepicker reliance on form-field's underlineRef * add spacing and alignment rules for outline variant * outline color & thickness * style tweaks * correctly position and size the gap * address comments * fix(form-field): correct prefix & suffix icons as well as select arrow for various form field appearances (#9743) * feat(input): add utilities for custom styling and monitoring state of input autofill (#9719) * add utility for monitoring input autofill * add scss mixin for styling input autofill colors * tests * move everything from cdk to MatInputModule * address comments * add doc comments * fix(form-field): fixes for outline appearance (#9759) * use the `AutofillMonitor` in `MatInput` * Make `updateOutlineGap` public so users can call it if needed * feat(chips): add ripple to chips (#9761) * fix(form-field, chips): fix tests & lint (#9767) * undo change that caused darkened color for legacy form field * fix change detection * fix(chips): remove margin for chip list (#9793) * add terminateOnPointerUp to ripple config

angular-automatic-lock-bot · 2019-09-08T07:01:05Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

mmalerba added 4 commits January 29, 2018 09:47

remove datepicker reliance on form-field's underlineRef

5a30888

add spacing and alignment rules for outline variant

1706343

outline color & thickness

eb37c19

style tweaks

9c25f9a

mmalerba assigned jelbourn Jan 30, 2018

mmalerba requested a review from jelbourn January 30, 2018 23:13

mmalerba requested review from crisbeto and kara as code owners January 30, 2018 23:13

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 30, 2018

correctly position and size the gap

15a591b

mmalerba force-pushed the input-chip branch from b335984 to 15a591b Compare January 30, 2018 23:13

jelbourn reviewed Jan 30, 2018

View reviewed changes

address comments

ac00b7a

mmalerba added the pr: needs review label Jan 31, 2018

jelbourn approved these changes Jan 31, 2018

View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 31, 2018

mmalerba merged commit 9d634f6 into angular:input-chip Jan 31, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(form-field): add outline style #9705

feat(form-field): add outline style #9705

Uh oh!

mmalerba commented Jan 30, 2018 •

edited

Loading

Uh oh!

jelbourn Jan 30, 2018

Uh oh!

ghost commented Jan 31, 2018 •

edited by ghost

Loading

Uh oh!

willshowell commented Jan 31, 2018

Uh oh!

mmalerba commented Jan 31, 2018

Uh oh!

mmalerba commented Jan 31, 2018

Uh oh!

jelbourn left a comment

Uh oh!

smile2014 commented Feb 2, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Uh oh!

feat(form-field): add outline style #9705

feat(form-field): add outline style #9705

Uh oh!

Conversation

mmalerba commented Jan 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jelbourn Jan 30, 2018

Choose a reason for hiding this comment

Uh oh!

ghost commented Jan 31, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

willshowell commented Jan 31, 2018

Uh oh!

mmalerba commented Jan 31, 2018

Uh oh!

mmalerba commented Jan 31, 2018

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

smile2014 commented Feb 2, 2018

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Uh oh!

mmalerba commented Jan 30, 2018 •

edited

Loading

ghost commented Jan 31, 2018 •

edited by ghost

Loading