Skip to content

Add the generatedSourcesPath to the project source roots again #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mensinda
Copy link

Followup for #191 to add back the generatedSourcesPath to the maven project paths.

This seems to work, but the solution feels a bit hacky.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@mensinda mensinda changed the title Add the ggeneratedSourcesPath to the project source roots again Add the generatedSourcesPath to the project source roots again Mar 11, 2025
@mensinda mensinda marked this pull request as draft March 11, 2025 10:11
@mensinda
Copy link
Author

I have converted this PR to a draft, since I made an alternative implementation in #312, which is cleaner IMHO.

@slawekjaranowski
Copy link
Member

@mensinda as #312 was merged I suppose that this can be closed

@slawekjaranowski slawekjaranowski added the waiting-for-feedback Waiting for 90 days until issues or pull request will be closed label Mar 15, 2025
@mensinda
Copy link
Author

Yes, with #312 merged, this is no longer needed.

@mensinda mensinda closed this Mar 15, 2025
@mensinda mensinda deleted the addGeneratedToProjectAgain branch March 15, 2025 17:11
@github-actions github-actions bot removed the waiting-for-feedback Waiting for 90 days until issues or pull request will be closed label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants