Skip to content

Add generatedSourcesPath back to the maven project #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mensinda
Copy link

This is a followup for for #191 to add the generatedSourcesPath back to the maven project paths as the final step of the mojo.

This is an alternative implementation to #311.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This is a followup for for apache#191 to add the generatedSourcesPath back
to the maven project paths as the final step of the mojo.
@oehme
Copy link

oehme commented Mar 12, 2025

LGTM

@slawekjaranowski This fixes the problem I mentioned

@slawekjaranowski slawekjaranowski added the bug Something isn't working label Mar 13, 2025
@slawekjaranowski slawekjaranowski merged commit d44d1be into apache:maven-compiler-plugin-3.x Mar 14, 2025
88 checks passed
@github-actions github-actions bot added this to the 3.14.1 milestone Mar 14, 2025
@slawekjaranowski slawekjaranowski linked an issue Mar 14, 2025 that may be closed by this pull request
@mensinda mensinda deleted the addGeneratedToProjectAgain2 branch March 15, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check last change from #191 against to MCOMPILER-157
3 participants