This repository was archived by the owner on Sep 30, 2021. It is now read-only.
Fix reversed order of evaluation of args in call to LineFollow::config #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C/C++ the order of evaluation of function arguments is unspecified.
In the particular case it was assumed that the calls to messageIn.readByte() in LineFollow::config() are evaluated from left to right. But that is not the case. In fact the evaluation order is from right to left with avr-gcc. At the end that caused the line follower application to work improperly.
The problem is solved by using additional variables like in the other cases of calls to messageIn.readByte() or messageIn.readInt().