Skip to content

Treat JUnit errors as failures to increase visibility #9698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

tlk
Copy link
Contributor

@tlk tlk commented Jan 31, 2020

Before this change cd app; ant test would return "BUILD SUCCESS"
even when unit tests were returning errors.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes

Please note: this change will make (already) failing tests break the "ant test" target.

Before this change `cd app; ant test` would return "BUILD SUCCESS"
even when unit tests were returning errors.
@tlk
Copy link
Contributor Author

tlk commented Jan 31, 2020

This is related to #9697 (Arduino IDE CI)

@cmaglie
Copy link
Member

cmaglie commented Feb 6, 2020

Ok now I see it, I guess this answer my question #9696 (comment)

@cmaglie cmaglie self-assigned this Feb 6, 2020
@cmaglie cmaglie added the Type: Improvement This proposal is considered to be especially beneficial label Feb 6, 2020
@cmaglie cmaglie merged commit ac6688d into arduino:master Feb 6, 2020
@cmaglie cmaglie added this to the Release 1.8.12 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement This proposal is considered to be especially beneficial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants